RE: [net-next v3 13/15] iecm: Add ethtool

2020-07-10 Thread Brady, Alan
oshua A ; Chittim, Madhu > ; Linga, Pavan Kumar > ; Skidmore, Donald C > ; Brandeburg, Jesse > ; Samudrala, Sridhar > > Subject: Re: [net-next v3 13/15] iecm: Add ethtool > > On Thu, 25 Jun 2020 19:07:35 -0700 Jeff Kirsher wrote: > > @@ -794,7 +824,57 @@ static void

RE: [net-next v3 13/15] iecm: Add ethtool

2020-06-29 Thread Brady, Alan
hua A ; Chittim, > Madhu ; Linga, Pavan Kumar > ; Skidmore, Donald C > ; Brandeburg, Jesse > ; Samudrala, Sridhar > > Subject: Re: [net-next v3 13/15] iecm: Add ethtool > > On Mon, 29 Jun 2020 21:00:57 + Brady, Alan wrote: > > > > +/* Helper macro

Re: [net-next v3 13/15] iecm: Add ethtool

2020-06-29 Thread Jakub Kicinski
On Mon, 29 Jun 2020 21:00:57 + Brady, Alan wrote: > > > +/* Helper macro to define an iecm_stat structure with proper size and > > > type. > > > + * Use this when defining constant statistics arrays. Note that > > > +@_type expects > > > + * only a type name and is used multiple times. > > > +

RE: [net-next v3 13/15] iecm: Add ethtool

2020-06-29 Thread Brady, Alan
oshua A ; Chittim, Madhu > ; Linga, Pavan Kumar > ; Skidmore, Donald C > ; Brandeburg, Jesse > ; Samudrala, Sridhar > > Subject: Re: [net-next v3 13/15] iecm: Add ethtool > > On Thu, 25 Jun 2020 19:07:35 -0700 Jeff Kirsher wrote: > > From: Alice Michael >

RE: [net-next v3 13/15] iecm: Add ethtool

2020-06-29 Thread Brady, Alan
oshua A ; Chittim, Madhu > ; Linga, Pavan Kumar > ; Skidmore, Donald C > ; Brandeburg, Jesse > ; Samudrala, Sridhar > > Subject: Re: [net-next v3 13/15] iecm: Add ethtool > > On Thu, 25 Jun 2020 19:07:35 -0700 Jeff Kirsher wrote: > > @@ -978,7 +1059,20 @@ static int iec

RE: [net-next v3 13/15] iecm: Add ethtool

2020-06-29 Thread Brady, Alan
oshua A ; Chittim, Madhu > ; Linga, Pavan Kumar > ; Skidmore, Donald C > ; Brandeburg, Jesse > ; Samudrala, Sridhar > > Subject: Re: [net-next v3 13/15] iecm: Add ethtool > > On Thu, 25 Jun 2020 19:07:35 -0700 Jeff Kirsher wrote: > > diff --git a/drivers/net/ethernet/

Re: [net-next v3 13/15] iecm: Add ethtool

2020-06-26 Thread Jakub Kicinski
On Thu, 25 Jun 2020 19:07:35 -0700 Jeff Kirsher wrote: > @@ -794,7 +824,57 @@ static void iecm_vc_event_task(struct work_struct *work) > int iecm_initiate_soft_reset(struct iecm_vport *vport, >enum iecm_flags reset_cause) > { > - /* stub */ > + struct iecm_adap

Re: [net-next v3 13/15] iecm: Add ethtool

2020-06-26 Thread Jakub Kicinski
On Thu, 25 Jun 2020 19:07:35 -0700 Jeff Kirsher wrote: > From: Alice Michael > > Implement ethtool interface for the common module. > > Signed-off-by: Alice Michael > Signed-off-by: Alan Brady > Signed-off-by: Phani Burra > Signed-off-by: Joshua Hay > Signed-off-by: Madhu Chittim > Signed-o

Re: [net-next v3 13/15] iecm: Add ethtool

2020-06-26 Thread Jakub Kicinski
On Thu, 25 Jun 2020 19:07:35 -0700 Jeff Kirsher wrote: > diff --git a/drivers/net/ethernet/intel/iecm/iecm_lib.c > b/drivers/net/ethernet/intel/iecm/iecm_lib.c > index d34834422049..a55151495e18 100644 > --- a/drivers/net/ethernet/intel/iecm/iecm_lib.c > +++ b/drivers/net/ethernet/intel/iecm/iecm_

Re: [net-next v3 13/15] iecm: Add ethtool

2020-06-26 Thread Jakub Kicinski
On Thu, 25 Jun 2020 19:07:35 -0700 Jeff Kirsher wrote: > @@ -978,7 +1059,20 @@ static int iecm_open(struct net_device *netdev) > */ > static int iecm_change_mtu(struct net_device *netdev, int new_mtu) > { > - /* stub */ > + struct iecm_vport *vport = iecm_netdev_to_vport(netdev); > + >

RE: [net-next v3 13/15] iecm: Add ethtool

2020-06-26 Thread Brady, Alan
oshua A ; Chittim, Madhu > ; Linga, Pavan Kumar > ; Skidmore, Donald C > ; Brandeburg, Jesse > ; Samudrala, Sridhar > > Subject: Re: [net-next v3 13/15] iecm: Add ethtool > > On Thu, 2020-06-25 at 19:07 -0700, Jeff Kirsher wrote: > > From: Alice Michael > > > >

Re: [net-next v3 13/15] iecm: Add ethtool

2020-06-25 Thread Joe Perches
On Thu, 2020-06-25 at 19:07 -0700, Jeff Kirsher wrote: > From: Alice Michael > > Implement ethtool interface for the common module. [] > diff --git a/drivers/net/ethernet/intel/iecm/iecm_ethtool.c > b/drivers/net/ethernet/intel/iecm/iecm_ethtool.c [] > +/* Stats associated with a Tx queue */ > +