RE: [net-next 1/4] e1000e: allow turning s0ix flows on for systems with ME

2020-11-30 Thread Limonciello, Mario
> On Mon, Nov 30, 2020 at 2:16 PM Limonciello, Mario > wrote: > > > > > > > > Generally the use of module parameters and sysfs usage are frowned > > > upon. > > > > I was trying to build on the existing module parameters that existed > > already for e1000e. So I guess I would ask, why are those

Re: [net-next 1/4] e1000e: allow turning s0ix flows on for systems with ME

2020-11-30 Thread Jakub Kicinski
On Mon, 30 Nov 2020 13:29:04 -0800 Tony Nguyen wrote: > From: Mario Limonciello > > S0ix for GBE flows are needed for allowing the system to get into deepest > power state, but these require coordination of components outside of > control of Linux kernel. For systems that have confirmed to coord

Re: [net-next 1/4] e1000e: allow turning s0ix flows on for systems with ME

2020-11-30 Thread Alexander Duyck
On Mon, Nov 30, 2020 at 2:16 PM Limonciello, Mario wrote: > > > > > Generally the use of module parameters and sysfs usage are frowned > > upon. > > I was trying to build on the existing module parameters that existed > already for e1000e. So I guess I would ask, why are those not done in > ethto

RE: [net-next 1/4] e1000e: allow turning s0ix flows on for systems with ME

2020-11-30 Thread Limonciello, Mario
> > Generally the use of module parameters and sysfs usage are frowned > upon. I was trying to build on the existing module parameters that existed already for e1000e. So I guess I would ask, why are those not done in ethtool? Should those parameters go away and they migrate to ethtool for the

Re: [net-next 1/4] e1000e: allow turning s0ix flows on for systems with ME

2020-11-30 Thread Alexander Duyck
On Mon, Nov 30, 2020 at 1:32 PM Tony Nguyen wrote: > > From: Mario Limonciello > > S0ix for GBE flows are needed for allowing the system to get into deepest > power state, but these require coordination of components outside of > control of Linux kernel. For systems that have confirmed to coordi