Re: [iproute2-next v2 1/1] devlink: display elapsed time during flash update

2020-10-13 Thread David Ahern
On 10/12/20 11:30 AM, Keller, Jacob E wrote: > Ah. Good point. This should use CLOCK_MONOTONIC instead, right? that or MONOTONIC_RAW.

RE: [iproute2-next v2 1/1] devlink: display elapsed time during flash update

2020-10-12 Thread Keller, Jacob E
> -Original Message- > From: David Ahern > Sent: Tuesday, October 06, 2020 10:56 PM > To: Keller, Jacob E ; netdev@vger.kernel.org; Jakub > Kicinski ; Shannon Nelson > Subject: Re: [iproute2-next v2 1/1] devlink: display elapsed time during flash > update > >

Re: [iproute2-next v2 1/1] devlink: display elapsed time during flash update

2020-10-06 Thread David Ahern
On 9/30/20 4:40 PM, Jacob Keller wrote: > @@ -3124,12 +3140,19 @@ static int cmd_dev_flash_status_cb(const struct > nlmsghdr *nlh, void *data) > done = > mnl_attr_get_u64(tb[DEVLINK_ATTR_FLASH_UPDATE_STATUS_DONE]); > if (tb[DEVLINK_ATTR_FLASH_UPDATE_STATUS_TOTAL]) >

Re: [iproute2-next v2 1/1] devlink: display elapsed time during flash update

2020-10-01 Thread Jiri Pirko
Thu, Oct 01, 2020 at 01:40:12AM CEST, jacob.e.kel...@intel.com wrote: >For some devices, updating the flash can take significant time during >operations where no status can meaningfully be reported. This can be >somewhat confusing to a user who sees devlink appear to hang on the >terminal waiting f

Re: [iproute2-next v2 1/1] devlink: display elapsed time during flash update

2020-09-30 Thread Shannon Nelson
On 9/30/20 4:40 PM, Jacob Keller wrote: For some devices, updating the flash can take significant time during operations where no status can meaningfully be reported. This can be somewhat confusing to a user who sees devlink appear to hang on the terminal waiting for the device to update. Recent