RE: [Resend][PATCH 01/05] ipv6: RFC4214 Support (4)

2007-11-12 Thread Templin, Fred L
> Ok, thanks for the explanation. One questions is though why > do we need all the #if defines() throughout the file? Was just trying to follow what I thought was convention, but I'm willing to be educated... > Most distros end up enabled almost everything anyway. Looking > at the code, there i

Re: [Resend][PATCH 01/05] ipv6: RFC4214 Support (4)

2007-11-12 Thread Vlad Yasevich
Hi Fred Templin, Fred L wrote: > Vlad, > > Yes, I was breaking into multiples to ease review only. > The "[PATCH 01/04] ... (5)" thread includes the complete > reviewable and patchable final text in 4 files. In my > next message, I will put the entire patchfile as inline > text. (The "[PATCH 01/0

RE: [Resend][PATCH 01/05] ipv6: RFC4214 Support (4)

2007-11-12 Thread Templin, Fred L
#x27;iproute2' is already complete.) Thanks - Fred [EMAIL PROTECTED] > -Original Message- > From: Vlad Yasevich [mailto:[EMAIL PROTECTED] > Sent: Monday, November 12, 2007 2:11 PM > To: Templin, Fred L > Cc: netdev@vger.kernel.org; [EMAIL PROTECTED] > Subject: Re: [Resend

Re: [Resend][PATCH 01/05] ipv6: RFC4214 Support (4)

2007-11-12 Thread Vlad Yasevich
Hi Fred First, are you breaking up the functionality into multiple patches _only_ to ease review and plan to submit the final version as a big patch? The reason I ask, is that you Patch 02, which adds Kconfig pieces could break compilations if the functionality is enabled. Templin, Fred L wrote