Re: [RFC 1/2] net/ethtool: Add new coalescing parameter for queue

2015-12-11 Thread David Miller
From: Ben Hutchings Date: Tue, 08 Dec 2015 19:00:52 + > On Tue, 2015-12-08 at 10:02 -0800, Shannon Nelson wrote: >> On Mon, Dec 7, 2015 at 8:42 PM,   wrote: >> > From: Kan Liang >> > >> > Intrdouce "queue" option for coalesce getting and setting. > [...] >> > --- a/net/core/ethtool.c >> > +

Re: [RFC 1/2] net/ethtool: Add new coalescing parameter for queue

2015-12-08 Thread Ben Hutchings
On Tue, 2015-12-08 at 19:43 +, Liang, Kan wrote: > > > > > On Tue, 2015-12-08 at 10:02 -0800, Shannon Nelson wrote: > > > On Mon, Dec 7, 2015 at 8:42 PM,   wrote: > > > > From: Kan Liang > > > > > > > > Intrdouce "queue" option for coalesce getting and setting. > > [...] > > > > --- a/net/c

RE: [RFC 1/2] net/ethtool: Add new coalescing parameter for queue

2015-12-08 Thread Liang, Kan
> > On Tue, 2015-12-08 at 10:02 -0800, Shannon Nelson wrote: > > On Mon, Dec 7, 2015 at 8:42 PM,   wrote: > > > From: Kan Liang > > > > > > Intrdouce "queue" option for coalesce getting and setting. > [...] > > > --- a/net/core/ethtool.c > > > +++ b/net/core/ethtool.c > > > @@ -1123,10 +1123,16

RE: [RFC 1/2] net/ethtool: Add new coalescing parameter for queue

2015-12-08 Thread Liang, Kan
> On 07/12/15 20:42, kan.li...@intel.com wrote: > > From: Kan Liang > > > > Intrdouce "queue" option for coalesce getting and setting. > > For coalesce getting, only the coalescing parameters from specific > > queue will be passed to user space. > > For coalesce setting, the coalescing parameter

RE: [RFC 1/2] net/ethtool: Add new coalescing parameter for queue

2015-12-08 Thread Liang, Kan
> > For that matter, if you've set different coalesce values on various queues, > what does asking for '-1' or "all the queues" mean and how should it return > info? Shouldn't all the specific queues be shown? Or do we now have to > do an ethtool command for each and every queue? > The only w

Re: [RFC 1/2] net/ethtool: Add new coalescing parameter for queue

2015-12-08 Thread Ben Hutchings
On Tue, 2015-12-08 at 10:02 -0800, Shannon Nelson wrote: > On Mon, Dec 7, 2015 at 8:42 PM,   wrote: > > From: Kan Liang > > > > Intrdouce "queue" option for coalesce getting and setting. [...] > > --- a/net/core/ethtool.c > > +++ b/net/core/ethtool.c > > @@ -1123,10 +1123,16 @@ static noinline_fo

Re: [RFC 1/2] net/ethtool: Add new coalescing parameter for queue

2015-12-08 Thread Florian Fainelli
On 07/12/15 20:42, kan.li...@intel.com wrote: > From: Kan Liang > > Intrdouce "queue" option for coalesce getting and setting. > For coalesce getting, only the coalescing parameters from specific > queue will be passed to user space. > For coalesce setting, the coalescing parameters will only be

Re: [RFC 1/2] net/ethtool: Add new coalescing parameter for queue

2015-12-08 Thread Shannon Nelson
On Mon, Dec 7, 2015 at 8:42 PM, wrote: > From: Kan Liang > > Intrdouce "queue" option for coalesce getting and setting. s/Intrdouce/Introduce/ > For coalesce getting, only the coalescing parameters from specific > queue will be passed to user space. > For coalesce setting, the coalescing param