Re: [PATCHv14 bpf-next 3/6] xdp: add a new helper for dev map multicast support

2021-01-18 Thread John Fastabend
Toke Høiland-Jørgensen wrote: > Hangbin Liu writes: > > > Hi John, > > > > Thanks for the reviewing. > > > > On Sun, Jan 17, 2021 at 04:10:40PM -0800, John Fastabend wrote: > >> > + * The forwarding *map* could be either > >> > BPF_MAP_TYPE_DEVMAP or > >> > + * BPF_MAP_

Re: [PATCHv14 bpf-next 3/6] xdp: add a new helper for dev map multicast support

2021-01-18 Thread Toke Høiland-Jørgensen
Hangbin Liu writes: > Hi John, > > Thanks for the reviewing. > > On Sun, Jan 17, 2021 at 04:10:40PM -0800, John Fastabend wrote: >> > + *The forwarding *map* could be either >> > BPF_MAP_TYPE_DEVMAP or >> > + *BPF_MAP_TYPE_DEVMAP_HASH. But the *ex_map* must be >>

Re: [PATCHv14 bpf-next 3/6] xdp: add a new helper for dev map multicast support

2021-01-18 Thread Hangbin Liu
Hi John, Thanks for the reviewing. On Sun, Jan 17, 2021 at 04:10:40PM -0800, John Fastabend wrote: > > + * The forwarding *map* could be either > > BPF_MAP_TYPE_DEVMAP or > > + * BPF_MAP_TYPE_DEVMAP_HASH. But the *ex_map* must be > > + * BPF_MAP_TY

RE: [PATCHv14 bpf-next 3/6] xdp: add a new helper for dev map multicast support

2021-01-17 Thread John Fastabend
Hangbin Liu wrote: > This patch is for xdp multicast support. which has been discussed > before[0], The goal is to be able to implement an OVS-like data plane in > XDP, i.e., a software switch that can forward XDP frames to multiple ports. > > To achieve this, an application needs to specify a gro