RE: [PATCHv1 5/7] TAP: Extending tap device create/destroy APIs

2017-01-17 Thread Grandhi, Sainath
ubject: Re: [PATCHv1 5/7] TAP: Extending tap device create/destroy APIs > > On Sat, Jan 7, 2017 at 12:33 AM, Sainath Grandhi > wrote: > > Extending tap APIs get/free_minor and create/destroy_cdev to handle > > more than one type of virtual interface. > > > > Signe

RE: [PATCHv1 5/7] TAP: Extending tap device create/destroy APIs

2017-01-17 Thread Grandhi, Sainath
> -Original Message- > From: Eric Dumazet [mailto:eric.duma...@gmail.com] > Sent: Friday, January 06, 2017 3:16 PM > To: Grandhi, Sainath > Cc: netdev@vger.kernel.org; da...@davemloft.net; > mah...@bandewar.net; linux-ker...@vger.kernel.org > Subject: Re: [PATCHv

Re: [PATCHv1 5/7] TAP: Extending tap device create/destroy APIs

2017-01-06 Thread Eric Dumazet
On Fri, 2017-01-06 at 14:33 -0800, Sainath Grandhi wrote: > +static int tap_list_add(dev_t major, const char *device_name) > +{ > + int err = 0; > + struct major_info *tap_major; > + > + tap_major = kzalloc(sizeof(*tap_major), GFP_ATOMIC); > + > + tap_major->major = MAJOR(major); >

Re: [PATCHv1 5/7] TAP: Extending tap device create/destroy APIs

2017-01-06 Thread Andy Shevchenko
On Sat, Jan 7, 2017 at 12:33 AM, Sainath Grandhi wrote: > Extending tap APIs get/free_minor and create/destroy_cdev to handle more than > one > type of virtual interface. > > Signed-off-by: Sainath Grandhi > Tested-by: Sainath Grandhi Usually it implies that commiter has tested the stuff. > -