RE: [PATCH v6 2/8] thunderbolt: Updating the register definitions

2016-09-11 Thread Levy, Amir (Jer)
On Sun, Sep 11 2016, 03:02 AM, Andreas Noever wrote: > On Mon, Aug 1, 2016 at 2:23 PM, Amir Levy wrote: > > Adding more Thunderbolt(TM) register definitions and some helper > > macros. > > Thinking about this again I would prefer it if you would put your definitions > into a separate file under i

Re: [PATCH v6 2/8] thunderbolt: Updating the register definitions

2016-09-10 Thread Andreas Noever
On Mon, Aug 1, 2016 at 2:23 PM, Amir Levy wrote: > Adding more Thunderbolt(TM) register definitions > and some helper macros. Thinking about this again I would prefer it if you would put your definitions into a separate file under icm/ (even if there is some duplication). The style (bitfields vs.