Re: [PATCH v4 bpf-next 00/13] mvneta: introduce XDP multi-buffer support

2020-10-08 Thread John Fastabend
Lorenzo Bianconi wrote: > > On Mon, 05 Oct 2020 21:29:36 -0700 > > John Fastabend wrote: > > > > > Lorenzo Bianconi wrote: > > > > [...] > > > > > > > > > > > > > > In general I see no reason to populate these fields before the XDP > > > > > program runs. Someone needs to convince me why havi

Re: [PATCH v4 bpf-next 00/13] mvneta: introduce XDP multi-buffer support

2020-10-06 Thread Lorenzo Bianconi
> On Mon, 05 Oct 2020 21:29:36 -0700 > John Fastabend wrote: > > > Lorenzo Bianconi wrote: > > > [...] > > > > > > > > > > > In general I see no reason to populate these fields before the XDP > > > > program runs. Someone needs to convince me why having frags info before > > > > program runs

RE: [PATCH v4 bpf-next 00/13] mvneta: introduce XDP multi-buffer support

2020-10-06 Thread Jubran, Samih
> -Original Message- > From: Daniel Borkmann > Sent: Friday, October 2, 2020 10:53 PM > To: John Fastabend ; Lorenzo Bianconi > ; b...@vger.kernel.org; netdev@vger.kernel.org > Cc: da...@davemloft.net; k...@kernel.org; a...@kernel.org; Agroskin, > Shay ; Jubran, Samih ; > dsah...@kernel.

Re: [PATCH v4 bpf-next 00/13] mvneta: introduce XDP multi-buffer support

2020-10-06 Thread Jesper Dangaard Brouer
On Mon, 05 Oct 2020 21:29:36 -0700 John Fastabend wrote: > Lorenzo Bianconi wrote: > > [...] > > > > > > > > In general I see no reason to populate these fields before the XDP > > > program runs. Someone needs to convince me why having frags info before > > > program runs is useful. In genera

Re: [PATCH v4 bpf-next 00/13] mvneta: introduce XDP multi-buffer support

2020-10-05 Thread John Fastabend
Lorenzo Bianconi wrote: > [...] > > > > > In general I see no reason to populate these fields before the XDP > > program runs. Someone needs to convince me why having frags info before > > program runs is useful. In general headers should be preserved and first > > frag already included in the da

Re: [PATCH v4 bpf-next 00/13] mvneta: introduce XDP multi-buffer support

2020-10-05 Thread Lorenzo Bianconi
[...] > > In general I see no reason to populate these fields before the XDP > program runs. Someone needs to convince me why having frags info before > program runs is useful. In general headers should be preserved and first > frag already included in the data pointers. If users start parsing fu

Re: [PATCH v4 bpf-next 00/13] mvneta: introduce XDP multi-buffer support

2020-10-05 Thread John Fastabend
Jesper Dangaard Brouer wrote: > On Fri, 02 Oct 2020 11:06:12 -0700 > John Fastabend wrote: > > > Lorenzo Bianconi wrote: > > > > Lorenzo Bianconi wrote: > > > > > This series introduce XDP multi-buffer support. The mvneta driver is > > > > > the first to support these new "non-linear" xdp_{buff

Re: [PATCH v4 bpf-next 00/13] mvneta: introduce XDP multi-buffer support

2020-10-05 Thread Tirthendu Sarkar
On 10/2/20 5:25 PM, John Fastabend wrote: >>[..] Typically for such features to land is to require at least 2 drivers >>implementing it. I am working on making changes to Intel NIC drivers for XDP multi buffer based on these patches. Respective patches Will be posted once ready.

Re: [PATCH v4 bpf-next 00/13] mvneta: introduce XDP multi-buffer support

2020-10-05 Thread Jesper Dangaard Brouer
On Fri, 02 Oct 2020 11:06:12 -0700 John Fastabend wrote: > Lorenzo Bianconi wrote: > > > Lorenzo Bianconi wrote: > > > > This series introduce XDP multi-buffer support. The mvneta driver is > > > > the first to support these new "non-linear" xdp_{buff,frame}. Reviewers > > > > please focus on h

Re: [PATCH v4 bpf-next 00/13] mvneta: introduce XDP multi-buffer support

2020-10-02 Thread Daniel Borkmann
On 10/2/20 5:25 PM, John Fastabend wrote: Lorenzo Bianconi wrote: This series introduce XDP multi-buffer support. The mvneta driver is the first to support these new "non-linear" xdp_{buff,frame}. Reviewers please focus on how these new types of xdp_{buff,frame} packets traverse the different la

Re: [PATCH v4 bpf-next 00/13] mvneta: introduce XDP multi-buffer support

2020-10-02 Thread John Fastabend
Lorenzo Bianconi wrote: > > Lorenzo Bianconi wrote: > > > This series introduce XDP multi-buffer support. The mvneta driver is > > > the first to support these new "non-linear" xdp_{buff,frame}. Reviewers > > > please focus on how these new types of xdp_{buff,frame} packets > > > traverse the diffe

Re: [PATCH v4 bpf-next 00/13] mvneta: introduce XDP multi-buffer support

2020-10-02 Thread Lorenzo Bianconi
> Lorenzo Bianconi wrote: > > This series introduce XDP multi-buffer support. The mvneta driver is > > the first to support these new "non-linear" xdp_{buff,frame}. Reviewers > > please focus on how these new types of xdp_{buff,frame} packets > > traverse the different layers and the layout design.

RE: [PATCH v4 bpf-next 00/13] mvneta: introduce XDP multi-buffer support

2020-10-02 Thread John Fastabend
Lorenzo Bianconi wrote: > This series introduce XDP multi-buffer support. The mvneta driver is > the first to support these new "non-linear" xdp_{buff,frame}. Reviewers > please focus on how these new types of xdp_{buff,frame} packets > traverse the different layers and the layout design. It is on