Re: [PATCH v4 01/16] vmxnet3: Move PCI Id to pci_ids.h

2016-09-20 Thread Bjorn Helgaas
On Wed, Sep 14, 2016 at 07:36:34PM +, Adit Ranadive wrote: > On Wed, Sep 14, 2016 at 09:25:18 -0700, Yuval Shaia wrote: > > On Wed, Sep 14, 2016 at 04:00:25PM +, Adit Ranadive wrote: > > > On Wed, Sep 14, 2016 at 04:09:12 -0700, Yuval Shaia wrote: > > > > Please update vmxnet3_drv.c accordi

Re: [PATCH v4 01/16] vmxnet3: Move PCI Id to pci_ids.h

2016-09-15 Thread Yuval Shaia
Besides that no more comments. Reviewed-by: Yuval Shaia On Wed, Sep 14, 2016 at 07:36:34PM +, Adit Ranadive wrote: > On Wed, Sep 14, 2016 at 09:25:18 -0700, Yuval Shaia wrote: > > On Wed, Sep 14, 2016 at 04:00:25PM +, Adit Ranadive wrote: > > > On Wed, Sep 14, 2016 at 04:09:12 -0700, Yuv

Re: [PATCH v4 01/16] vmxnet3: Move PCI Id to pci_ids.h

2016-09-14 Thread Adit Ranadive
On Wed, Sep 14, 2016 at 09:25:18 -0700, Yuval Shaia wrote: > On Wed, Sep 14, 2016 at 04:00:25PM +, Adit Ranadive wrote: > > On Wed, Sep 14, 2016 at 04:09:12 -0700, Yuval Shaia wrote: > > > Please update vmxnet3_drv.c accordingly. > > > > Any reason why? I don't think we need to. Vmxnet3 should

Re: [PATCH v4 01/16] vmxnet3: Move PCI Id to pci_ids.h

2016-09-14 Thread Yuval Shaia
On Wed, Sep 14, 2016 at 04:00:25PM +, Adit Ranadive wrote: > On Wed, Sep 14, 2016 at 04:09:12 -0700, Yuval Shaia wrote: > > Please update vmxnet3_drv.c accordingly. > > Any reason why? I don't think we need to. Vmxnet3 should just pick up the > moved > PCI device id from pci_ids.h file. So n

RE: [PATCH v4 01/16] vmxnet3: Move PCI Id to pci_ids.h

2016-09-14 Thread Adit Ranadive
On Wed, Sep 14, 2016 at 04:09:12 -0700, Yuval Shaia wrote: > Please update vmxnet3_drv.c accordingly. Any reason why? I don't think we need to. Vmxnet3 should just pick up the moved PCI device id from pci_ids.h file. - Adit

Re: [PATCH v4 01/16] vmxnet3: Move PCI Id to pci_ids.h

2016-09-14 Thread Yuval Shaia
Please update vmxnet3_drv.c accordingly. Yuval On Sun, Sep 11, 2016 at 09:49:11PM -0700, Adit Ranadive wrote: > The VMXNet3 PCI Id will be shared with our paravirtual RDMA driver. > Moved it to the shared location in pci_ids.h. > > Suggested-by: Leon Romanovsky > Signed-off-by: Adit Ranadive >

Re: [PATCH v4 01/16] vmxnet3: Move PCI Id to pci_ids.h

2016-09-12 Thread Bjorn Helgaas
On Sun, Sep 11, 2016 at 09:49:11PM -0700, Adit Ranadive wrote: > The VMXNet3 PCI Id will be shared with our paravirtual RDMA driver. > Moved it to the shared location in pci_ids.h. > > Suggested-by: Leon Romanovsky > Signed-off-by: Adit Ranadive Acked-by: Bjorn Helgaas > --- > --- > drivers/