On 22/07/20, 3:48 AM, "Haiyang Zhang" wrote:
> If you make this change, did you see any drop in a live test? The
> "packet->total_bytes" in struct hv_netvsc_packet is for book keeping
> only, which is used for stats info, and not visible by the host at all.
> I made this sugg
M
> M (nimm) ; xe-linux-external(mailer list) exter...@cisco.com>; k...@kernel.org; linux-hyp...@vger.kernel.org;
> netdev@vger.kernel.org; linux-ker...@vger.kernel.org
> Subject: Re: [PATCH v3] net: hyperv: add support for vlans in netvsc driver
>
>
>
> On 21/07/20, 4:57
On 21/07/20, 4:57 AM, "David Miller" wrote:
From: Sriram Krishnan
Date: Mon, 20 Jul 2020 22:15:51 +0530
> + if (skb->protocol == htons(ETH_P_8021Q)) {
> + u16 vlan_tci = 0;
> + skb_reset_mac_header(skb);
> Please place an empty line between basic block
From: Sriram Krishnan
Date: Mon, 20 Jul 2020 22:15:51 +0530
> + if (skb->protocol == htons(ETH_P_8021Q)) {
> + u16 vlan_tci = 0;
> + skb_reset_mac_header(skb);
Please place an empty line between basic block local variable declarations
and actual code.
> +
> -Original Message-
> From: Sriram Krishnan
> Sent: Monday, July 20, 2020 12:46 PM
> To: KY Srinivasan ; Haiyang Zhang
> ; Stephen Hemminger ;
> Wei Liu
> Cc: mbumg...@cisco.com; u...@cisco.com; n...@cisco.com; xe-linux-
> exter...@cisco.com; David S. Miller ; Jakub Kicinski
> ; linux
> -Original Message-
> From: Sriram Krishnan
> Sent: Monday, July 20, 2020 12:46 PM
> To: KY Srinivasan ; Haiyang Zhang
> ; Stephen Hemminger ;
> Wei Liu
> Cc: mbumg...@cisco.com; u...@cisco.com; n...@cisco.com; xe-linux-
> exter...@cisco.com; David S. Miller ; Jakub Kicinski
> ; linux
On Mon, 20 Jul 2020 22:15:51 +0530
Sriram Krishnan wrote:
>
> + /* When using AF_PACKET we need to remove VLAN from frame
> + * and indicate VLAN information in SKB so HOST OS will
> + * transmit the VLAN frame
> + */
> + if (skb->protocol == htons(ETH_P_8021Q)) {
> +
