Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-12-13 Thread Ilias Apalodimas
Hi Ioanna > > > > > > Well if you don't have to use 64kb pages you can use the page_pool API > > (only > > > used from mlx5 atm) and get the xdp recycling for free. The memory > > 'waste' > > > for > > > 4kb pages isn't too much if the platforms the driver sits on have decent > > > amounts > > > of

RE: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-12-13 Thread Ioana Ciocoi Radulescu
@vger.kernel.org; da...@davemloft.net; Ioana Ciornei > > ; dsah...@gmail.com; Camelia Alexandra Groza > > > > Subject: Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support > > > > Hi Ioana, > > > > > > > > > > I only did a quick gr

RE: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-12-07 Thread Ioana Ciocoi Radulescu
Subject: Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support > > Hi Ioana, > > > > > > > > I only did a quick grep around the driver so i might be missing something, > > > but i can only see allocations via napi_alloc_frag(). XDP requires pages >

Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-12-07 Thread Ilias Apalodimas
Hi Ioana, > > > > > > I only did a quick grep around the driver so i might be missing something, > > but i can only see allocations via napi_alloc_frag(). XDP requires pages > > (either a single page per packet or a driver that does the page management > > of > > its own and fits 2 frames in a sing

RE: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-12-07 Thread Ioana Ciocoi Radulescu
> Subject: Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support > > Hi Ioana, > > > > > > > Add support for XDP programs. Only XDP_PASS, XDP_DROP and > XDP_TX > > > > actions are supported for now. Frame header changes are also > > > &

Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-12-07 Thread Ilias Apalodimas
Hi Ioana, > > > > > Add support for XDP programs. Only XDP_PASS, XDP_DROP and XDP_TX > > > actions are supported for now. Frame header changes are also > > > allowed. I only did a quick grep around the driver so i might be missing something, but i can only see allocations via napi_alloc_frag().

RE: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-12-07 Thread Ioana Ciocoi Radulescu
za ; Ilias Apalodimas > > Subject: Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support > > On Mon, 26 Nov 2018 16:27:28 + > Ioana Ciocoi Radulescu wrote: > > > Add support for XDP programs. Only XDP_PASS, XDP_DROP and XDP_TX > > actions are supported for now. Fra

Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-12-05 Thread Jesper Dangaard Brouer
On Mon, 26 Nov 2018 16:27:28 + Ioana Ciocoi Radulescu wrote: > Add support for XDP programs. Only XDP_PASS, XDP_DROP and XDP_TX > actions are supported for now. Frame header changes are also > allowed. Do you have any XDP performance benchmarks on this hardware? Also what boards (and arch's

Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-11-28 Thread David Miller
From: Ioana Ciocoi Radulescu Date: Wed, 28 Nov 2018 09:18:28 + > They apply cleanly for me. I figured out what happend. The patches were mis-ordered (specifically patches #3 and #4) when I added them to the patchwork bundle, and that is what causes them to fail. Series applied, thanks!

Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-11-28 Thread David Ahern
xandra Groza >> Subject: Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support >> >> From: Ioana Ciocoi Radulescu >> Date: Mon, 26 Nov 2018 16:27:28 + >> >>> Add support for XDP programs. Only XDP_PASS, XDP_DROP and XDP_TX >>> actions are s

RE: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-11-28 Thread Ioana Ciocoi Radulescu
> -Original Message- > From: David Miller > Sent: Wednesday, November 28, 2018 2:25 AM > To: Ioana Ciocoi Radulescu > Cc: netdev@vger.kernel.org; Ioana Ciornei ; > dsah...@gmail.com; Camelia Alexandra Groza > Subject: Re: [PATCH v2 net-next 0/8] dpaa2-eth:

Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-11-27 Thread David Miller
From: Ioana Ciocoi Radulescu Date: Mon, 26 Nov 2018 16:27:28 + > Add support for XDP programs. Only XDP_PASS, XDP_DROP and XDP_TX > actions are supported for now. Frame header changes are also > allowed. > > v2: - count the XDP packets in the rx/tx inteface stats > - add message with the