Re: [PATCH v2 net] bnx2x: Fix busy_poll vs netpoll

2015-04-15 Thread David Miller
From: Eric Dumazet Date: Tue, 14 Apr 2015 18:45:00 -0700 > From: Eric Dumazet > > Commit 9a2620c877454 ("bnx2x: prevent WARN during driver unload") > switched the napi/busy_lock locking mechanism from spin_lock() into > spin_lock_bh(), breaking inter-operability with netconsole, as netpoll > di

Re: [PATCH v2 net] bnx2x: Fix busy_poll vs netpoll

2015-04-15 Thread Eric Dumazet
On Wed, 2015-04-15 at 14:03 +, Yuval Mintz wrote: > > > > > > BTW, this looks quite generic - isn't it possible to take it out of > > > the driver and push it into the networking core, uniforming it in the > > > process? > > > > Yes, this is the plan I have in mind, once net-next is opened ag

RE: [PATCH v2 net] bnx2x: Fix busy_poll vs netpoll

2015-04-15 Thread Yuval Mintz
> > > > BTW, this looks quite generic - isn't it possible to take it out of > > the driver and push it into the networking core, uniforming it in the > > process? > > Yes, this is the plan I have in mind, once net-next is opened again ;) > > Thanks ! > I'm not familiar with any real strong tes

Re: [PATCH v2 net] bnx2x: Fix busy_poll vs netpoll

2015-04-15 Thread Eric Dumazet
On Wed, 2015-04-15 at 04:05 +, Yuval Mintz wrote: > > #ifdef CONFIG_NET_RX_BUSY_POLL > > -static inline void bnx2x_fp_init_lock(struct bnx2x_fastpath *fp) > > + > > +enum bnx2x_fp_state { > > + BNX2X_STATE_FP_NAPI = BIT(0), /* NAPI handler owns the queue */ > > + > > + BNX2X_ST