Re: [PATCH v2 4/6] ethtool: support per-queue sub command --show-coalesce

2019-02-07 Thread Michal Kubecek
On Thu, Feb 07, 2019 at 11:53:40PM +, Nunley, Nicholas D wrote: > > > @@ -5390,7 +5438,19 @@ static int do_perqueue(struct cmd_context *ctx) > > > if (i < 0) > > > exit_bad_args(); > > > > > > - /* no sub_command support yet */ > > > + if (strstr(args[i].opts, "--show-coalesce") !=

RE: [PATCH v2 4/6] ethtool: support per-queue sub command --show-coalesce

2019-02-07 Thread Nunley, Nicholas D
bject: Re: [PATCH v2 4/6] ethtool: support per-queue sub command -- > show-coalesce > > On Tue, Feb 05, 2019 at 04:01:04PM -0800, Jeff Kirsher wrote: > > diff --git a/ethtool.c b/ethtool.c > > index 4dc725c..9a1b83b 100644 > > --- a/ethtool.c > > +++ b/ethtool.c

Re: [PATCH v2 4/6] ethtool: support per-queue sub command --show-coalesce

2019-02-06 Thread Michal Kubecek
On Tue, Feb 05, 2019 at 04:01:04PM -0800, Jeff Kirsher wrote: > diff --git a/ethtool.c b/ethtool.c > index 4dc725c..9a1b83b 100644 > --- a/ethtool.c > +++ b/ethtool.c > @@ -1409,6 +1409,29 @@ static int dump_coalesce(const struct ethtool_coalesce > *ecoal) > return 0; > } > > +void dump_p