Re: [PATCH v2 1/1] ath10k: add option for chip-id based BDF selection

2020-12-07 Thread Abhishek Kumar
Hi, > > (no changes since v1) > > I think you need to work on the method you're using to generate your > patches. There are most definitely changes since v1. You described > them in your cover letter (which you don't really need for a singleton > patch) instead of here. I agree, this was not int

Re: [PATCH v2 1/1] ath10k: add option for chip-id based BDF selection

2020-12-03 Thread Doug Anderson
Hi, On Thu, Dec 3, 2020 at 3:33 AM Rakesh Pillai wrote: > > > What I'm trying to say is this. Imagine that: > > > > a) the device tree has the "variant" property. > > > > b) the BRD file has two entries, one for "board-id" (1) and one for > > "board-id + chip-id" (2). It doesn't have one for "b

RE: [PATCH v2 1/1] ath10k: add option for chip-id based BDF selection

2020-12-03 Thread Rakesh Pillai
t: Re: [PATCH v2 1/1] ath10k: add option for chip-id based BDF > selection > > Hi, > > On Tue, Nov 24, 2020 at 7:44 PM Rakesh Pillai > wrote: > > > > > > I missed on reviewing this change. Also I agree with Doug that this is > > > > not >

Re: [PATCH v2 1/1] ath10k: add option for chip-id based BDF selection

2020-11-30 Thread Doug Anderson
Hi, On Tue, Nov 24, 2020 at 7:44 PM Rakesh Pillai wrote: > > > > I missed on reviewing this change. Also I agree with Doug that this is not > > the change I was looking for. > > > > > > The argument "with_variant" can be renamed to "with_extra_params". > > There is no need for any new argument to

RE: [PATCH v2 1/1] ath10k: add option for chip-id based BDF selection

2020-11-24 Thread Rakesh Pillai
6:27 AM > > > To: Abhishek Kumar > > > Cc: Kalle Valo ; Rakesh Pillai > > > ; LKML ; ath10k > > > ; Brian Norris ; > > > linux-wireless ; David S. Miller > > > ; Jakub Kicinski ; netdev > > > > > > Subject: Re: [PATCH

Re: [PATCH v2 1/1] ath10k: add option for chip-id based BDF selection

2020-11-24 Thread Doug Anderson
Norris ; > > linux-wireless ; David S. Miller > > ; Jakub Kicinski ; netdev > > > > Subject: Re: [PATCH v2 1/1] ath10k: add option for chip-id based BDF > > selection > > > > Hi, > > > > On Thu, Nov 12, 2020 at 12:09 PM Abhishek Kumar > &

RE: [PATCH v2 1/1] ath10k: add option for chip-id based BDF selection

2020-11-24 Thread Rakesh Pillai
t: Re: [PATCH v2 1/1] ath10k: add option for chip-id based BDF > selection > > Hi, > > On Thu, Nov 12, 2020 at 12:09 PM Abhishek Kumar > wrote: > > > > In some devices difference in chip-id should be enough to pick > > the right BDF. Add another support for chi

Re: [PATCH v2 1/1] ath10k: add option for chip-id based BDF selection

2020-11-23 Thread Doug Anderson
Hi, On Thu, Nov 12, 2020 at 12:09 PM Abhishek Kumar wrote: > > In some devices difference in chip-id should be enough to pick > the right BDF. Add another support for chip-id based BDF selection. > With this new option, ath10k supports 2 fallback options. > > The board name with chip-id as option