Re: [PATCH v2 1/1] NetLabel: secid reconciliation support

2006-10-02 Thread Paul Moore
Stephen Smalley wrote: > On Mon, 2006-10-02 at 14:06 -0400, [EMAIL PROTECTED] wrote: > >>plain text document attachment (netlabel-secid_support) >>This patch provides the missing NetLabel support to the secid reconciliation >>patchset. >> >>Signed-off-by: Paul Moore <[EMAIL PROTECTED]> >>--- >> se

RE: [PATCH v2 1/1] NetLabel: secid reconciliation support

2006-10-02 Thread Venkat Yekkirala
> > If this selinux_netlbl_skb_sid() call can fail for any > reason other than > > a kernel bug, then this needs to goto out instead of using > BUG_ON. For > > example, if the function can fail due to temporary memory pressure > > leading to a failed allocation, then you want to simply > drop t

Re: [PATCH v2 1/1] NetLabel: secid reconciliation support

2006-10-02 Thread Paul Moore
Stephen Smalley wrote: > On Mon, 2006-10-02 at 14:06 -0400, [EMAIL PROTECTED] wrote: > >>plain text document attachment (netlabel-secid_support) >>This patch provides the missing NetLabel support to the secid reconciliation >>patchset. >> >>Signed-off-by: Paul Moore <[EMAIL PROTECTED]> >>--- >> se

Re: [PATCH v2 1/1] NetLabel: secid reconciliation support

2006-10-02 Thread Stephen Smalley
On Mon, 2006-10-02 at 14:06 -0400, [EMAIL PROTECTED] wrote: > plain text document attachment (netlabel-secid_support) > This patch provides the missing NetLabel support to the secid reconciliation > patchset. > > Signed-off-by: Paul Moore <[EMAIL PROTECTED]> > --- > security/selinux/hooks.c