RE: [PATCH v2] ravb: Fixed the problem that rmmod can not be done

2020-08-05 Thread ashid...@fujitsu.com
Hi Sergei, >The subject also could be more concise... I'll think about it. Thank you! > Not at all so common as I thought! Only 4 drivers use mdio-bitbang, > 2 of them are for the Renesas SoCs... Yes. > Do yuo have R-Car V3H at hand, by chance? It does have a GEther > controler use

RE: [PATCH v2] ravb: Fixed the problem that rmmod can not be done

2020-08-05 Thread ashid...@fujitsu.com
Hi Sergei, >CCing DaveM (as you should have done from the start)... Thank you. I appreciate your help. >Did you also build mdio-bitbang.c as a module? Yes. Sure. > For the in-kernal driver, not being able to rmmod the 'ravb' one sounds > logical. :-) root@rcar-gen3:~# lsmod|grep ravb

Re: [PATCH v2] ravb: Fixed the problem that rmmod can not be done

2020-07-31 Thread Sergei Shtylyov
On 7/30/20 1:01 PM, Yuusuke Ashizuka wrote: CCing DaveM (as you should have done from the start)... > ravb is a module driver, but I cannot rmmod it after insmod it. > ravb does mdio_init() at the time of probe, and module->refcnt is incremented > by alloc_mdio_bitbang() called after that. > T

Re: [PATCH v2] ravb: Fixed the problem that rmmod can not be done

2020-07-31 Thread Sergei Shtylyov
Hello! On 7/31/20 9:43 AM, Yoshihiro Shimoda wrote: From: Yuusuke Ashizuka, Sent: Thursday, July 30, 2020 7:02 PM Subject: [PATCH v2] ravb: Fixed the problem that rmmod can not be done >>> >>> Thank you for the patch! I found a similar patch for another driver [1]. >> >>It's not th

Re: [PATCH v2] ravb: Fixed the problem that rmmod can not be done

2020-07-31 Thread Sergei Shtylyov
Hello! On 7/31/20 1:18 PM, ashid...@fujitsu.com wrote: > I understand that the commit log needs to be corrected. The subject also could be more concise... > (Shimoda-san's point is also correct) > > If there is anything else that needs to be corrected, please point it out. OK, I'll try

RE: [PATCH v2] ravb: Fixed the problem that rmmod can not be done

2020-07-31 Thread ashid...@fujitsu.com
> -Original Message- > From: Sergei Shtylyov > Sent: Friday, July 31, 2020 1:04 AM > To: Ashizuka, Yuusuke/芦塚 雄介 > Cc: netdev@vger.kernel.org; linux-renesas-...@vger.kernel.org > Subject: Re: [PATCH v2] ravb: Fixed the problem that rmmod can not > be done > > He

RE: [PATCH v2] ravb: Fixed the problem that rmmod can not be done

2020-07-30 Thread Yoshihiro Shimoda
Hello! > From: Sergei Shtylyov, Sent: Friday, July 31, 2020 1:24 AM > > Hello! > > On 7/30/20 2:37 PM, Yoshihiro Shimoda wrote: > > >> From: Yuusuke Ashizuka, Sent: Thursday, July 30, 2020 7:02 PM > >> Subject: [PATCH v2] ravb: Fixed the problem that rmmod can not be done > > > > Thank you for

Re: [PATCH v2] ravb: Fixed the problem that rmmod can not be done

2020-07-30 Thread Sergei Shtylyov
Hello! On 7/30/20 2:37 PM, Yoshihiro Shimoda wrote: >> From: Yuusuke Ashizuka, Sent: Thursday, July 30, 2020 7:02 PM >> Subject: [PATCH v2] ravb: Fixed the problem that rmmod can not be done > > Thank you for the patch! I found a similar patch for another driver [1]. It's not the same case -

Re: [PATCH v2] ravb: Fixed the problem that rmmod can not be done

2020-07-30 Thread Sergei Shtylyov
Hello! On 7/30/20 1:01 PM, Yuusuke Ashizuka wrote: > ravb is a module driver, but I cannot rmmod it after insmod it. Modular. And "insmod'ing it". > ravb does mdio_init() at the time of probe, and module->refcnt is incremented > by alloc_mdio_bitbang() called after that. That seems a com

RE: [PATCH v2] ravb: Fixed the problem that rmmod can not be done

2020-07-30 Thread Yoshihiro Shimoda
Hi Ashizuka-san, > From: Yuusuke Ashizuka, Sent: Thursday, July 30, 2020 7:02 PM > Subject: [PATCH v2] ravb: Fixed the problem that rmmod can not be done Thank you for the patch! I found a similar patch for another driver [1]. So, we should apply this patch to the ravb driver. [1] fd5f375c1628 (