RE: [PATCH v2] e1000e: Increase iteration on polling MDIC ready bit

2020-09-26 Thread David Laight
From: Andrew Lunn > Sent: 25 September 2020 14:29 > On Fri, Sep 25, 2020 at 08:50:30AM +, David Laight wrote: > > From: Kai-Heng Feng > > > Sent: 24 September 2020 17:04 > > ... > > > > I also don't fully understand the fix. You are now looping up to 6400 > > > > times, each with a delay of 50u

Re: [PATCH v2] e1000e: Increase iteration on polling MDIC ready bit

2020-09-25 Thread Andrew Lunn
On Fri, Sep 25, 2020 at 08:50:30AM +, David Laight wrote: > From: Kai-Heng Feng > > Sent: 24 September 2020 17:04 > ... > > > I also don't fully understand the fix. You are now looping up to 6400 > > > times, each with a delay of 50uS. So that is around 12800 times more > > > than it actually n

RE: [PATCH v2] e1000e: Increase iteration on polling MDIC ready bit

2020-09-25 Thread David Laight
From: Kai-Heng Feng > Sent: 24 September 2020 17:04 ... > > I also don't fully understand the fix. You are now looping up to 6400 > > times, each with a delay of 50uS. So that is around 12800 times more > > than it actually needs to transfer the 64 bits! I've no idea how this > > hardware works, bu

Re: [PATCH v2] e1000e: Increase iteration on polling MDIC ready bit

2020-09-24 Thread Kai-Heng Feng
Hi Andrew, > On Sep 24, 2020, at 23:53, Andrew Lunn wrote: > > On Thu, Sep 24, 2020 at 11:09:58PM +0800, Kai-Heng Feng wrote: >> We are seeing the following error after S3 resume: >> [ 704.746874] e1000e :00:1f.6 eno1: Setting page 0x6020 >> [ 704.844232] e1000e :00:1f.6 eno1: MDI Writ

Re: [PATCH v2] e1000e: Increase iteration on polling MDIC ready bit

2020-09-24 Thread Andrew Lunn
On Thu, Sep 24, 2020 at 11:09:58PM +0800, Kai-Heng Feng wrote: > We are seeing the following error after S3 resume: > [ 704.746874] e1000e :00:1f.6 eno1: Setting page 0x6020 > [ 704.844232] e1000e :00:1f.6 eno1: MDI Write did not complete > [ 704.902817] e1000e :00:1f.6 eno1: Setting