Re: [PATCH net v2 2/3] xfrm: Add an activate() offload dev op

2017-12-04 Thread Shannon Nelson
Subject: Re: [PATCH net v2 2/3] xfrm: Add an activate() offload dev op On 12/1/2017 11:47 AM, Shannon Nelson wrote: On 11/28/2017 9:55 AM, av...@mellanox.com wrote: From: Aviv Heller Adding the state to the offload device prior to replay init in xfrm_state_construct() will result in NULL

RE: [PATCH net v2 2/3] xfrm: Add an activate() offload dev op

2017-12-03 Thread Yossi Kuperman
gt; Subject: Re: [PATCH net v2 2/3] xfrm: Add an activate() offload dev op > > On 12/1/2017 11:47 AM, Shannon Nelson wrote: > > On 11/28/2017 9:55 AM, av...@mellanox.com wrote: > >> From: Aviv Heller > >> > >> Adding the state to the offload device prior

RE: [PATCH net v2 2/3] xfrm: Add an activate() offload dev op

2017-12-03 Thread Yossi Kuperman
Subject: Re: [PATCH net v2 2/3] xfrm: Add an activate() offload dev op > > On 12/2/2017 2:33 PM, Yossi Kuperman wrote: > > > > > >>> On 1 Dec 2017, at 9:09, Steffen Klassert > wrote: > >>> > >>> On Tue, Nov 28, 2017 at 07:55:41PM +0200, av

RE: [PATCH net v2 2/3] xfrm: Add an activate() offload dev op

2017-12-03 Thread Yossi Kuperman
> -Original Message- > From: Boris Pismenny > Sent: Sunday, December 3, 2017 1:29 PM > To: Yossi Kuperman ; Steffen Klassert > > Cc: Aviv Heller ; Herbert Xu > ; Yevgeny Kliteynik ; > netdev@vger.kernel.org > Subject: RE: [PATCH net v2 2/3] xfrm: Add a

RE: [PATCH net v2 2/3] xfrm: Add an activate() offload dev op

2017-12-03 Thread Boris Pismenny
> -Original Message- > From: Yossi Kuperman > Sent: Sunday, December 03, 2017 00:34 > To: Steffen Klassert > Cc: Aviv Heller ; Herbert Xu > ; Boris Pismenny ; > Yevgeny Kliteynik ; netdev@vger.kernel.org > Subject: Re: [PATCH net v2 2/3] xfrm: Add an a

Re: [PATCH net v2 2/3] xfrm: Add an activate() offload dev op

2017-12-02 Thread Shannon Nelson
On 12/2/2017 2:33 PM, Yossi Kuperman wrote: On 1 Dec 2017, at 9:09, Steffen Klassert wrote: On Tue, Nov 28, 2017 at 07:55:41PM +0200, av...@mellanox.com wrote: From: Aviv Heller Adding the state to the offload device prior to replay init in xfrm_state_construct() will result in NULL derefe

Re: [PATCH net v2 2/3] xfrm: Add an activate() offload dev op

2017-12-02 Thread Yossi Kuperman
>> On 1 Dec 2017, at 9:09, Steffen Klassert >> wrote: >> >> On Tue, Nov 28, 2017 at 07:55:41PM +0200, av...@mellanox.com wrote: >> From: Aviv Heller >> >> Adding the state to the offload device prior to replay init in >> xfrm_state_construct() will result in NULL dereference if a matching >>

Re: [PATCH net v2 2/3] xfrm: Add an activate() offload dev op

2017-12-02 Thread Shannon Nelson
On 12/1/2017 11:47 AM, Shannon Nelson wrote: On 11/28/2017 9:55 AM, av...@mellanox.com wrote: From: Aviv Heller Adding the state to the offload device prior to replay init in xfrm_state_construct() will result in NULL dereference if a matching ESP packet is received in between. In order to in

Re: [PATCH net v2 2/3] xfrm: Add an activate() offload dev op

2017-12-01 Thread Shannon Nelson
On 11/28/2017 9:55 AM, av...@mellanox.com wrote: From: Aviv Heller Adding the state to the offload device prior to replay init in xfrm_state_construct() will result in NULL dereference if a matching ESP packet is received in between. In order to inhibit driver offload logic from processing the

Re: [PATCH net v2 2/3] xfrm: Add an activate() offload dev op

2017-11-30 Thread Steffen Klassert
On Tue, Nov 28, 2017 at 07:55:41PM +0200, av...@mellanox.com wrote: > From: Aviv Heller > > Adding the state to the offload device prior to replay init in > xfrm_state_construct() will result in NULL dereference if a matching > ESP packet is received in between. > > In order to inhibit driver of