Re: [PATCH net v2 1/3] net: phy: Fix PHY module checks

2017-02-08 Thread Florian Fainelli
On 02/07/2017 11:57 PM, maowenan wrote: > > >> -Original Message- >> From: Florian Fainelli [mailto:f.faine...@gmail.com] >> Sent: Wednesday, February 08, 2017 3:38 PM >> To: netdev@vger.kernel.org >> Cc: da...@davemloft.net; and...@lunn.ch; rmk+ker...@armlinux.org.uk; >> maowenan; Floria

Re: [PATCH net v2 1/3] net: phy: Fix PHY module checks

2017-02-08 Thread Florian Fainelli
On 02/08/2017 08:57 AM, Andrew Lunn wrote: >> --- a/drivers/net/phy/phy_device.c >> +++ b/drivers/net/phy/phy_device.c >> @@ -920,7 +920,7 @@ int phy_attach_direct(struct net_device *dev, struct >> phy_device *phydev, >> return -EIO; >> } >> >> -if (!try_module_get(d->drive

Re: [PATCH net v2 1/3] net: phy: Fix PHY module checks

2017-02-08 Thread Andrew Lunn
> --- a/drivers/net/phy/phy_device.c > +++ b/drivers/net/phy/phy_device.c > @@ -920,7 +920,7 @@ int phy_attach_direct(struct net_device *dev, struct > phy_device *phydev, > return -EIO; > } > > - if (!try_module_get(d->driver->owner)) { > + if (d->driver && !try_modul

Re: [PATCH net v2 1/3] net: phy: Fix PHY module checks

2017-02-08 Thread Fabio Estevam
On Wed, Feb 8, 2017 at 5:37 AM, Florian Fainelli wrote: > The Generic PHY drivers gets assigned after we checked that the current PHY > driver is NULL, so we need to check a few things before we can safely > derference d->driver. Update phy_attach_direct() and phy_detach() accordingly > to be resi

RE: [PATCH net v2 1/3] net: phy: Fix PHY module checks

2017-02-07 Thread maowenan
> -Original Message- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Wednesday, February 08, 2017 3:38 PM > To: netdev@vger.kernel.org > Cc: da...@davemloft.net; and...@lunn.ch; rmk+ker...@armlinux.org.uk; > maowenan; Florian Fainelli > Subject: [PATCH net v2 1/3] net: phy: