RE: [PATCH net v2] enetc: Avoid implicit sign extension

2021-03-30 Thread David Laight
From: Vladimir Oltean > Sent: 29 March 2021 17:24 > > On Mon, Mar 29, 2021 at 05:14:43PM +0300, Claudiu Manoil wrote: > > Static analysis tool reports: > > "Suspicious implicit sign extension - 'flags' with type u8 (8 bit, > > unsigned) is promoted in 'flags' << 24 to type int (32 bits, signed), >

RE: [PATCH net v2] enetc: Avoid implicit sign extension

2021-03-29 Thread Claudiu Manoil
>-Original Message- >From: Vladimir Oltean >Sent: Monday, March 29, 2021 7:24 PM >To: Claudiu Manoil >Cc: netdev@vger.kernel.org; Jakub Kicinski ; David S . >Miller >Subject: Re: [PATCH net v2] enetc: Avoid implicit sign extension > >On Mon, Mar 29, 2021 a

Re: [PATCH net v2] enetc: Avoid implicit sign extension

2021-03-29 Thread Vladimir Oltean
On Mon, Mar 29, 2021 at 05:14:43PM +0300, Claudiu Manoil wrote: > Static analysis tool reports: > "Suspicious implicit sign extension - 'flags' with type u8 (8 bit, > unsigned) is promoted in 'flags' << 24 to type int (32 bits, signed), > then sign-extended to type unsigned long long (64 bits, unsi