Re: [PATCH net-next v7] Add support of Cavium Liquidio ethernet adapters

2015-04-27 Thread David Miller
From: "Chickles, Derek" Date: Mon, 27 Apr 2015 17:04:35 + > >> >> >> >> It is extremely disappointing that you've defined your own debug >> >> logging macros, which use generic dev_*() printks, instead of using >> >> the proper netdev_*() printk logging interfaces to do this. >> > >> > We ca

RE: [PATCH net-next v7] Add support of Cavium Liquidio ethernet adapters

2015-04-27 Thread Chickles, Derek
> >> > >> It is extremely disappointing that you've defined your own debug > >> logging macros, which use generic dev_*() printks, instead of using > >> the proper netdev_*() printk logging interfaces to do this. > > > > We can make this change. I'm not sure why it was missed since we > > have net

RE: [PATCH net-next v7] Add support of Cavium Liquidio ethernet adapters

2015-04-27 Thread Chickles, Derek
> > It is extremely disappointing that you've defined your own debug > logging macros, which use generic dev_*() printks, instead of using > the proper netdev_*() printk logging interfaces to do this. We can make this change. I'm not sure why it was missed since we have netif_level support. Pleas

Re: [PATCH net-next v7] Add support of Cavium Liquidio ethernet adapters

2015-04-27 Thread David Miller
From: "Chickles, Derek" Date: Mon, 27 Apr 2015 16:26:27 + >> >> It is extremely disappointing that you've defined your own debug >> logging macros, which use generic dev_*() printks, instead of using >> the proper netdev_*() printk logging interfaces to do this. > > We can make this change.

Re: [PATCH net-next v7] Add support of Cavium Liquidio ethernet adapters

2015-04-26 Thread David Miller
From: Raghu Vatsavayi Date: Fri, 24 Apr 2015 17:34:16 -0700 > Following patch adds support for Cavium Liquidio ethernet adapter. > LiquidIO adapters are pci express based 10Gig server adapters. > > This patch v7 has changes based on the feedback from earlier patches: > > 1) Minor comments from