Re: [PATCH net-next v4 4/5] bnx2x: Use NETIF_F_GRO_HW.

2017-12-14 Thread Michael Chan
On Thu, Dec 14, 2017 at 11:07 PM, Chopra, Manish wrote: > Michael, I checked it on again, I tried to set LRO in dev->features and > dev->hw_features. > Somehow, it gets disabled after register_netdevice(). Any idea why ? > Although, I am not running any Bridge/bonding devices. > Looks like, wi

RE: [PATCH net-next v4 4/5] bnx2x: Use NETIF_F_GRO_HW.

2017-12-14 Thread Chopra, Manish
nux L2 > Subject: Re: [PATCH net-next v4 4/5] bnx2x: Use NETIF_F_GRO_HW. > > On Wed, Dec 13, 2017 at 1:08 AM, Chopra, Manish > wrote: > > > > Hi Michael, There seems a behavioral change here. This driver support > > two HW aggregation modes [LRO and GRO] With the cha

Re: [PATCH net-next v4 4/5] bnx2x: Use NETIF_F_GRO_HW.

2017-12-14 Thread Michael Chan
On Wed, Dec 13, 2017 at 11:46 PM, Chopra, Manish wrote: > > 2). In bnx2x_fix_features() we used to do before these changes - > > /* TPA requires Rx CSUM offloading */ > if (!(features & NETIF_F_RXCSUM)) { > features &= ~NETIF_F_LRO; > features &= ~N

RE: [PATCH net-next v4 4/5] bnx2x: Use NETIF_F_GRO_HW.

2017-12-13 Thread Chopra, Manish
nux L2 > Subject: Re: [PATCH net-next v4 4/5] bnx2x: Use NETIF_F_GRO_HW. > > On Wed, Dec 13, 2017 at 1:08 AM, Chopra, Manish > wrote: > > > > Hi Michael, There seems a behavioral change here. This driver support > > two HW aggregation modes [LRO and GRO] With the cha

Re: [PATCH net-next v4 4/5] bnx2x: Use NETIF_F_GRO_HW.

2017-12-13 Thread Michael Chan
On Wed, Dec 13, 2017 at 1:08 AM, Chopra, Manish wrote: > > Hi Michael, There seems a behavioral change here. This driver support two HW > aggregation modes [LRO and GRO] > With the changes, Interfaces come with HW GRO enabled and LRO disabled by > default as opposed to earlier where interfaces

RE: [PATCH net-next v4 4/5] bnx2x: Use NETIF_F_GRO_HW.

2017-12-13 Thread Chopra, Manish
> -Original Message- > From: Michael Chan [mailto:michael.c...@broadcom.com] > Sent: Monday, December 11, 2017 5:11 PM > To: da...@davemloft.net > Cc: netdev@vger.kernel.org; andrew.gospoda...@broadcom.com; Elior, Ariel > ; Dept-Eng Everest Linux L2 engeverestlinu...@cavium.com> > Subject: