> > > + if (device_property_read_u32(&pdev->dev, "version", &version)) {
> > > + dev_err(&pdev->dev, "Version Info not found\n");
> > > + return -EINVAL;
> > > + }
> >
> > Is this a device tree property? ACPI? If it is device tree property you
> > need to
> > document the binding,
> -Original Message-
> From: Andrew Lunn
> Sent: Thursday, March 11, 2021 9:20 PM
> To: David Thompson
> Cc: netdev@vger.kernel.org; da...@davemloft.net; k...@kernel.org; Liming
> Sun ; Asmaa Mnebhi
> Subject: Re: [PATCH net-next v4] Add Mellanox BlueField Gigab
> -Original Message-
> From: Andrew Lunn
> Sent: Thursday, March 11, 2021 8:57 PM
> To: David Thompson
> Cc: netdev@vger.kernel.org; da...@davemloft.net; k...@kernel.org; Liming
> Sun ; Asmaa Mnebhi
> Subject: Re: [PATCH net-next v4] Add Mellanox BlueField Gigab
> +#define DRV_VERSION 1.19
> +static int mlxbf_gige_probe(struct platform_device *pdev)
> +{
> + unsigned int phy_int_gpio;
> + struct phy_device *phydev;
> + struct net_device *netdev;
> + struct resource *mac_res;
> + struct resource *llu_res;
> + struct resource *plu_re
> +static void mlxbf_gige_get_pauseparam(struct net_device *netdev,
> + struct ethtool_pauseparam *pause)
> +{
> + struct mlxbf_gige *priv = netdev_priv(netdev);
> +
> + pause->autoneg = priv->aneg_pause;
> + pause->rx_pause = priv->tx_pause;
> + pa
