Re: [PATCH net-next v3 4/7] vxlan: improve vxlan route lookup checks.

2016-11-21 Thread Pravin Shelar
On Thu, Nov 17, 2016 at 7:59 AM, Jiri Benc wrote: > On Thu, 17 Nov 2016 10:17:01 +, David Laight wrote: >> Worse than arbitrary, it adds 4 bytes of pad on 64bit systems. > > It does not, this is not a struct. > right. After looking at the assembly code, it is clear that GCC and most of modern

Re: [PATCH net-next v3 4/7] vxlan: improve vxlan route lookup checks.

2016-11-17 Thread Pravin Shelar
On Thu, Nov 17, 2016 at 2:17 AM, David Laight wrote: > From: Of Jiri Benc >> Sent: 15 November 2016 14:40 >> On Sun, 13 Nov 2016 20:43:55 -0800, Pravin B Shelar wrote: >> > @@ -1929,8 +1951,8 @@ static void vxlan_xmit_one(struct sk_buff *skb, >> > struct net_device *dev, >> > union vxlan_addr

Re: [PATCH net-next v3 4/7] vxlan: improve vxlan route lookup checks.

2016-11-17 Thread David Miller
From: Jiri Benc Date: Thu, 17 Nov 2016 16:59:49 +0100 > On Thu, 17 Nov 2016 10:17:01 +, David Laight wrote: >> Worse than arbitrary, it adds 4 bytes of pad on 64bit systems. > > It does not, this is not a struct. He is talking about on the function stack.

Re: [PATCH net-next v3 4/7] vxlan: improve vxlan route lookup checks.

2016-11-17 Thread Jiri Benc
On Thu, 17 Nov 2016 10:17:01 +, David Laight wrote: > Worse than arbitrary, it adds 4 bytes of pad on 64bit systems. It does not, this is not a struct. Jiri

RE: [PATCH net-next v3 4/7] vxlan: improve vxlan route lookup checks.

2016-11-17 Thread David Laight
From: Of Jiri Benc > Sent: 15 November 2016 14:40 > On Sun, 13 Nov 2016 20:43:55 -0800, Pravin B Shelar wrote: > > @@ -1929,8 +1951,8 @@ static void vxlan_xmit_one(struct sk_buff *skb, > > struct net_device *dev, > > union vxlan_addr *src; > > struct vxlan_metadata _md; > > struct vxla

Re: [PATCH net-next v3 4/7] vxlan: improve vxlan route lookup checks.

2016-11-15 Thread Jiri Benc
On Sun, 13 Nov 2016 20:43:55 -0800, Pravin B Shelar wrote: > @@ -1929,8 +1951,8 @@ static void vxlan_xmit_one(struct sk_buff *skb, struct > net_device *dev, > union vxlan_addr *src; > struct vxlan_metadata _md; > struct vxlan_metadata *md = &_md; > - struct dst_entry *ndst =