RE: [PATCH net-next v3 1/7] ethtool: Extend link modes settings uAPI with lanes

2021-02-02 Thread Danielle Ratson
; Subject: Re: [PATCH net-next v3 1/7] ethtool: Extend link modes settings uAPI > with lanes > > On Wed, Jan 20, 2021 at 3:21 AM Danielle Ratson wrote: > > > -#define __DEFINE_LINK_MODE_PARAMS(_speed, _type, _duplex) \ > > +#define __DEFINE_LINK_MODE_PARAMS(_speed, _t

Re: [PATCH net-next v3 1/7] ethtool: Extend link modes settings uAPI with lanes

2021-01-26 Thread Jakub Kicinski
On Mon, 25 Jan 2021 15:53:24 + Danielle Ratson wrote: > > > @@ -353,10 +358,39 @@ static int ethnl_update_linkmodes(struct > > > genl_info *info, struct nlattr **tb, > > > > > > *mod = false; > > > req_speed = tb[ETHTOOL_A_LINKMODES_SPEED]; > > > + req_lanes = tb[ETHTOOL_A_LINKMODES_LANES];

RE: [PATCH net-next v3 1/7] ethtool: Extend link modes settings uAPI with lanes

2021-01-25 Thread Danielle Ratson
ect: Re: [PATCH net-next v3 1/7] ethtool: Extend link modes settings uAPI > with lanes > > On Wed, 20 Jan 2021 11:37:07 +0200 Danielle Ratson wrote: > > Currently, when auto negotiation is on, the user can advertise all the > > linkmodes which correspond to a specific speed,

Re: [PATCH net-next v3 1/7] ethtool: Extend link modes settings uAPI with lanes

2021-01-21 Thread Jakub Kicinski
On Wed, 20 Jan 2021 11:37:07 +0200 Danielle Ratson wrote: > Currently, when auto negotiation is on, the user can advertise all the > linkmodes which correspond to a specific speed, but does not have a > similar selector for the number of lanes. This is significant when a > specific speed can be ach

Re: [PATCH net-next v3 1/7] ethtool: Extend link modes settings uAPI with lanes

2021-01-20 Thread Edwin Peer
On Wed, Jan 20, 2021 at 3:21 AM Danielle Ratson wrote: > -#define __DEFINE_LINK_MODE_PARAMS(_speed, _type, _duplex) \ > +#define __DEFINE_LINK_MODE_PARAMS(_speed, _type, _lanes, _duplex) \ > [ETHTOOL_LINK_MODE(_speed, _type, _duplex)] = { \ > .speed = SPEED_ ## _speed, \