RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-25 Thread Parav Pandit
idhar > > ; da...@davemloft.net; > > netdev@vger.kernel.org; oss-driv...@netronome.com > > Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on > > devlink PCI ports > > > > Thu, Mar 21, 2019 at 06:42:55PM CET, pa...@mellanox.com wrote: > > > > &g

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-22 Thread Parav Pandit
v Pandit > >> Cc: Jakub Kicinski ; Samudrala, Sridhar > >> ; da...@davemloft.net; > >> netdev@vger.kernel.org; oss-driv...@netronome.com > >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on > >> devlink PCI ports > >> > >> Thu, M

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-22 Thread Parav Pandit
v Pandit > >> Cc: Jakub Kicinski ; Samudrala, Sridhar > >> ; da...@davemloft.net; > >> netdev@vger.kernel.org; oss-driv...@netronome.com > >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on > >> devlink PCI ports > >> > >> Thu, M

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-22 Thread Jiri Pirko
t.net; >> netdev@vger.kernel.org; oss-driv...@netronome.com >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI >> ports >> >> Thu, Mar 21, 2019 at 05:52:09PM CET, pa...@mellanox.com wrote: >> > >> > >> >> -Original Mes

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-22 Thread Jiri Pirko
t.net; >> netdev@vger.kernel.org; oss-driv...@netronome.com >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI >> ports >> >> Thu, Mar 21, 2019 at 05:50:37PM CET, pa...@mellanox.com wrote: >> > >> > >> >> -Original Mes

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-21 Thread Parav Pandit
v Pandit > >> Cc: Jakub Kicinski ; Samudrala, Sridhar > >> ; da...@davemloft.net; > >> netdev@vger.kernel.org; oss-driv...@netronome.com > >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on > >> devlink PCI ports > >> > >>

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-21 Thread Jiri Pirko
t.net; >> netdev@vger.kernel.org; oss-driv...@netronome.com >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI >> ports >> >> Thu, Mar 21, 2019 at 04:03:58PM CET, pa...@mellanox.com wrote: >> >Hi Jiri, >> > >> >> -Orig

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-21 Thread Parav Pandit
v Pandit > >> Cc: Jakub Kicinski ; Samudrala, Sridhar > >> ; da...@davemloft.net; > >> netdev@vger.kernel.org; oss-driv...@netronome.com > >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on > >> devlink PCI ports > >> > >> Thu, M

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-21 Thread Jiri Pirko
t.net; >> netdev@vger.kernel.org; oss-driv...@netronome.com >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI >> ports >> >> Thu, Mar 21, 2019 at 04:14:53PM CET, pa...@mellanox.com wrote: >> > >> > >> >> -Original Mess

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-21 Thread Parav Pandit
b Kicinski > >> Cc: Parav Pandit ; Samudrala, Sridhar > >> ; da...@davemloft.net; > >> netdev@vger.kernel.org; oss-driv...@netronome.com > >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on > >> devlink PCI ports > >> > >> Mon, Ma

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-21 Thread Parav Pandit
b Kicinski > >> Cc: Parav Pandit ; Samudrala, Sridhar > >> ; da...@davemloft.net; > >> netdev@vger.kernel.org; oss-driv...@netronome.com > >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on > >> devlink PCI ports > >> > >

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-21 Thread Jiri Pirko
t.net; >> netdev@vger.kernel.org; oss-driv...@netronome.com >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI >> ports >> >> Wed, Mar 20, 2019 at 09:22:57PM CET, jakub.kicin...@netronome.com >> wrote: >> >On Wed,

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-21 Thread Jiri Pirko
t.net; >> netdev@vger.kernel.org; oss-driv...@netronome.com >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI >> ports >> >> Mon, Mar 18, 2019 at 08:16:42PM CET, jakub.kicin...@netronome.com >> wrote: >> >On Mon, 18 Mar 2019 13:11:

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-21 Thread Parav Pandit
> -Original Message- > From: Jiri Pirko > Sent: Thursday, March 21, 2019 3:45 AM > To: Jakub Kicinski > Cc: Parav Pandit ; Samudrala, Sridhar > ; da...@davemloft.net; > netdev@vger.kernel.org; oss-driv...@netronome.com > Subject: Re: [PATCH net-next v2 4/7] de

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-21 Thread Parav Pandit
Hi Jiri, > -Original Message- > From: Jiri Pirko > Sent: Thursday, March 21, 2019 4:08 AM > To: Jakub Kicinski > Cc: Parav Pandit ; Samudrala, Sridhar > ; da...@davemloft.net; > netdev@vger.kernel.org; oss-driv...@netronome.com > Subject: Re: [PATCH net-nex

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-21 Thread Jiri Pirko
Mon, Mar 18, 2019 at 08:19:00PM CET, jakub.kicin...@netronome.com wrote: >On Mon, 18 Mar 2019 13:21:05 +0100, Jiri Pirko wrote: >> >First two entries shows the link between hostport and switchport. >> >$ devlink port show >> >pci/:05:00.0/10002 eth netdev flavour switchport switch_id 00154d130d

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-21 Thread Jiri Pirko
Wed, Mar 20, 2019 at 09:22:57PM CET, jakub.kicin...@netronome.com wrote: >On Wed, 20 Mar 2019 18:24:15 +, Parav Pandit wrote: >> Hi Jiri, Jakub, Samudrala Sridhar, >> > > > > > And physical port in include/uapi/linux/devlink.h also describe >> > > > > > that. >> > > > > >> > > > > By "that" y

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-21 Thread Jiri Pirko
Mon, Mar 18, 2019 at 08:16:42PM CET, jakub.kicin...@netronome.com wrote: >On Mon, 18 Mar 2019 13:11:54 +0100, Jiri Pirko wrote: >> >> >2. flavour should not be vf/pf, flavour should be hostport, switchport. >> >> >Because switch is flat and agnostic of pf/vf/mdev. >> >> >> >> Not sure. It's go

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-20 Thread Parav Pandit
> -Original Message- > From: Jakub Kicinski > Sent: Wednesday, March 20, 2019 3:23 PM > To: Parav Pandit > Cc: Jiri Pirko ; Samudrala, Sridhar > ; da...@davemloft.net; > netdev@vger.kernel.org; oss-driv...@netronome.com > Subject: Re: [PATCH net-next v2 4/7] de

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-20 Thread Jakub Kicinski
On Wed, 20 Mar 2019 18:24:15 +, Parav Pandit wrote: > Hi Jiri, Jakub, Samudrala Sridhar, > > > > > > And physical port in include/uapi/linux/devlink.h also describe > > > > > > that. > > > > > > > > > > By "that" you must mean that the physical is a user facing port. > > > > > > > > Can you

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-20 Thread Parav Pandit
ger.kernel.org; oss-driv...@netronome.com > Subject: RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI > ports > > > > > -Original Message- > > From: Jakub Kicinski > > Sent: Monday, March 18, 2019 4:30 PM > > To: Parav Pandit &g

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-18 Thread Parav Pandit
> -Original Message- > From: Jakub Kicinski > Sent: Monday, March 18, 2019 4:30 PM > To: Parav Pandit > Cc: Jiri Pirko ; Samudrala, Sridhar > ; da...@davemloft.net; > netdev@vger.kernel.org; oss-driv...@netronome.com > Subject: Re: [PATCH net-next v2 4/7] de

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-18 Thread Jakub Kicinski
On Mon, 18 Mar 2019 20:35:02 +, Parav Pandit wrote: > > > > > physical and pf has some overlapping definitions. > > > > > > > > What "overlapping definitions" do physical and PF have? > > > PF has physically user facing port. > > > > PF doesn't "have a user facing port" in switchdev mode

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-18 Thread Parav Pandit
Cc: Jiri Pirko ; Samudrala, Sridhar > > > ; da...@davemloft.net; > > > netdev@vger.kernel.org; oss-driv...@netronome.com > > > Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on > > > devlink PCI ports > > > > > > On Mon,

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-18 Thread Jakub Kicinski
vger.kernel.org; oss-driv...@netronome.com > > Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI > > ports > > > > On Mon, 18 Mar 2019 16:22:33 +, Parav Pandit wrote: > > >>>>>>2. flavour should not be vf/pf, flavour sho

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-18 Thread Parav Pandit
> -Original Message- > From: Jakub Kicinski > Sent: Monday, March 18, 2019 2:37 PM > To: Parav Pandit > Cc: Jiri Pirko ; Samudrala, Sridhar > ; da...@davemloft.net; > netdev@vger.kernel.org; oss-driv...@netronome.com > Subject: Re: [PATCH net-next v2 4/7] de

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-18 Thread Parav Pandit
> -Original Message- > From: Jakub Kicinski > Sent: Monday, March 18, 2019 2:19 PM > To: Jiri Pirko > Cc: Parav Pandit ; Samudrala, Sridhar > ; da...@davemloft.net; > netdev@vger.kernel.org; oss-driv...@netronome.com > Subject: Re: [PATCH net-next v2 4/7] de

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-18 Thread Jakub Kicinski
On Mon, 18 Mar 2019 16:22:33 +, Parav Pandit wrote: >>2. flavour should not be vf/pf, flavour should be hostport, switchport. >>> >Because switch is flat and agnostic of pf/vf/mdev. > > Not sure. It's good to have this kind of visibility. > port can have label/attribut

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-18 Thread Jakub Kicinski
vger.kernel.org; oss-driv...@netronome.com > > Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI > > ports > > > > On Fri, 15 Mar 2019 22:12:13 +, Parav Pandit wrote: > > > > On Fri, 15 Mar 2019 21:08:14 +0100, Jiri Pirko wrot

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-18 Thread Jakub Kicinski
On Mon, 18 Mar 2019 13:21:05 +0100, Jiri Pirko wrote: > >First two entries shows the link between hostport and switchport. > >$ devlink port show > >pci/:05:00.0/10002 eth netdev flavour switchport switch_id 00154d130d2f > >peer pci/:05:00.0/1 > > > >pci/:05:00.0/1 eth netdev flavour h

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-18 Thread Jakub Kicinski
On Mon, 18 Mar 2019 13:11:54 +0100, Jiri Pirko wrote: > >> >2. flavour should not be vf/pf, flavour should be hostport, switchport. > >> >Because switch is flat and agnostic of pf/vf/mdev. > >> > >> Not sure. It's good to have this kind of visibility. > > > >Yes, this subthread honestly make

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-18 Thread Parav Pandit
inski > > ; da...@davemloft.net; > > netdev@vger.kernel.org; oss-driv...@netronome.com > > Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on > > devlink PCI ports > > > > Fri, Mar 15, 2019 at 10:59:33PM CET, pa...@mellanox.com wrote: > > > >

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-18 Thread Parav Pandit
; >> Cc: Samudrala, Sridhar ; Jakub Kicinski > >> ; da...@davemloft.net; > >> netdev@vger.kernel.org; oss-driv...@netronome.com > >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on > >> devlink PCI ports > >> > >>

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-18 Thread Parav Pandit
> -Original Message- > From: Jakub Kicinski > Sent: Friday, March 15, 2019 8:16 PM > To: Parav Pandit > Cc: Jiri Pirko ; Samudrala, Sridhar > ; da...@davemloft.net; > netdev@vger.kernel.org; oss-driv...@netronome.com > Subject: Re: [PATCH net-next v2 4/7] de

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-18 Thread Jiri Pirko
t.net; >> netdev@vger.kernel.org; oss-driv...@netronome.com >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI >> ports >> >> Fri, Mar 15, 2019 at 04:32:24PM CET, pa...@mellanox.com wrote: >> > >> > >> >> -Original Me

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-18 Thread Jiri Pirko
Fri, Mar 15, 2019 at 09:44:54PM CET, jakub.kicin...@netronome.com wrote: >On Fri, 15 Mar 2019 21:08:14 +0100, Jiri Pirko wrote: >> >> IIUC, Jiri/Jakub are proposing creation of 2 devlink objects for each >> >> port - >> >> host facing ports and switch facing ports. This is in addition to the >> >

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-15 Thread Jakub Kicinski
On Fri, 15 Mar 2019 22:12:13 +, Parav Pandit wrote: > > On Fri, 15 Mar 2019 21:08:14 +0100, Jiri Pirko wrote: > > > >> IIUC, Jiri/Jakub are proposing creation of 2 devlink objects for > > > >> each port - host facing ports and switch facing ports. This is in > > > >> addition to the netdevs t

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-15 Thread Parav Pandit
> -Original Message- > From: Jakub Kicinski > Sent: Friday, March 15, 2019 3:45 PM > To: Jiri Pirko > Cc: Parav Pandit ; Samudrala, Sridhar > ; da...@davemloft.net; > netdev@vger.kernel.org; oss-driv...@netronome.com > Subject: Re: [PATCH net-next v2 4/7] de

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-15 Thread Parav Pandit
dit ; Jakub Kicinski > >> > >> Cc: Jiri Pirko ; da...@davemloft.net; > >> netdev@vger.kernel.org; oss-driv...@netronome.com > >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on > >> devlink PCI ports > >> > >> > >

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-15 Thread Jakub Kicinski
On Fri, 15 Mar 2019 21:08:14 +0100, Jiri Pirko wrote: > >> IIUC, Jiri/Jakub are proposing creation of 2 devlink objects for each port > >> - > >> host facing ports and switch facing ports. This is in addition to the > >> netdevs > >> that are created today. To be clear I'm not in favour of the d

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-15 Thread Jiri Pirko
t.net; >> netdev@vger.kernel.org; oss-driv...@netronome.com >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI >> ports >> >> >> On 3/14/2019 7:40 PM, Parav Pandit wrote: >> > >> > >> >> -Original Message-

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-15 Thread Parav Pandit
icinski > >> > >> Cc: Jiri Pirko ; da...@davemloft.net; > >> netdev@vger.kernel.org; oss-driv...@netronome.com > >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on > >> devlink PCI ports > >> > >> > >> > >&g

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-15 Thread Jiri Pirko
Thu, Mar 14, 2019 at 11:09:45PM CET, jakub.kicin...@netronome.com wrote: >On Thu, 14 Mar 2019 08:38:40 +0100, Jiri Pirko wrote: >> Wed, Mar 13, 2019 at 05:55:55PM CET, jakub.kicin...@netronome.com wrote: >> >On Wed, 13 Mar 2019 17:22:43 +0100, Jiri Pirko wrote: >> >> Wed, Mar 13, 2019 at 05:17:31

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-14 Thread Parav Pandit
andit > >> Cc: Jiri Pirko ; da...@davemloft.net; > >> netdev@vger.kernel.org; oss-driv...@netronome.com > >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on > >> devlink PCI ports > >> > >> On Thu, 14 Mar 2019 22:35:36 +, Parav Pandit wrot

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-14 Thread Samudrala, Sridhar
On 3/14/2019 6:28 PM, Parav Pandit wrote: -Original Message- From: Jakub Kicinski Sent: Thursday, March 14, 2019 6:39 PM To: Parav Pandit Cc: Jiri Pirko ; da...@davemloft.net; netdev@vger.kernel.org; oss-driv...@netronome.com Subject: Re: [PATCH net-next v2 4/7] devlink: allow

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-14 Thread Parav Pandit
> -Original Message- > From: Parav Pandit > Sent: Thursday, March 14, 2019 8:29 PM > To: 'Jakub Kicinski' > Cc: Jiri Pirko ; da...@davemloft.net; > netdev@vger.kernel.org; oss-driv...@netronome.com > Subject: RE: [PATCH net-next v2 4/7] devlink: allow

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-14 Thread Parav Pandit
> -Original Message- > From: Jakub Kicinski > Sent: Thursday, March 14, 2019 6:39 PM > To: Parav Pandit > Cc: Jiri Pirko ; da...@davemloft.net; > netdev@vger.kernel.org; oss-driv...@netronome.com > Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports o

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-14 Thread Jakub Kicinski
On Thu, 14 Mar 2019 22:35:36 +, Parav Pandit wrote: > > > Then instances of flavour pci_vf are going to appear in the same > > > devlink instance. Those are the switch ports: > > > pci/:05:00.0/10002: type eth netdev enp5s0npf0pf0s0 > > > flavour pci_vf pf 0 vf 0 > >

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-14 Thread Parav Pandit
Hi Jakub, > -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Jakub Kicinski > Sent: Thursday, March 14, 2019 5:10 PM > To: Jiri Pirko > Cc: da...@davemloft.net; netdev@vger.kernel.org; oss- > driv...@netronome.com > Subject: Re: [PATCH

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-14 Thread Jakub Kicinski
On Thu, 14 Mar 2019 08:38:40 +0100, Jiri Pirko wrote: > Wed, Mar 13, 2019 at 05:55:55PM CET, jakub.kicin...@netronome.com wrote: > >On Wed, 13 Mar 2019 17:22:43 +0100, Jiri Pirko wrote: > >> Wed, Mar 13, 2019 at 05:17:31PM CET, jakub.kicin...@netronome.com wrote: > >> >On Wed, 13 Mar 2019 07:07

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-14 Thread Jiri Pirko
Wed, Mar 13, 2019 at 05:55:55PM CET, jakub.kicin...@netronome.com wrote: >On Wed, 13 Mar 2019 17:22:43 +0100, Jiri Pirko wrote: >> Wed, Mar 13, 2019 at 05:17:31PM CET, jakub.kicin...@netronome.com wrote: >> >On Wed, 13 Mar 2019 07:07:01 +0100, Jiri Pirko wrote: >> >> Tue, Mar 12, 2019 at 09:56:28

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-13 Thread Jakub Kicinski
On Wed, 13 Mar 2019 17:22:43 +0100, Jiri Pirko wrote: > Wed, Mar 13, 2019 at 05:17:31PM CET, jakub.kicin...@netronome.com wrote: > >On Wed, 13 Mar 2019 07:07:01 +0100, Jiri Pirko wrote: > >> Tue, Mar 12, 2019 at 09:56:28PM CET, jakub.kicin...@netronome.com wrote: > >> >On Tue, 12 Mar 2019 15:02

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-13 Thread Jiri Pirko
Wed, Mar 13, 2019 at 05:03:17PM CET, sridhar.samudr...@intel.com wrote: >On 3/13/2019 12:37 AM, Jiri Pirko wrote: >> Wed, Mar 13, 2019 at 07:17:04AM CET, sridhar.samudr...@intel.com wrote: >> > >> > On 3/12/2019 7:02 AM, Jiri Pirko wrote: >> > >> > > >> > > > >> > > > > I originally planned to

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-13 Thread Jiri Pirko
Wed, Mar 13, 2019 at 05:17:31PM CET, jakub.kicin...@netronome.com wrote: >On Wed, 13 Mar 2019 07:07:01 +0100, Jiri Pirko wrote: >> Tue, Mar 12, 2019 at 09:56:28PM CET, jakub.kicin...@netronome.com wrote: >> >On Tue, 12 Mar 2019 15:02:39 +0100, Jiri Pirko wrote: >> >> Tue, Mar 12, 2019 at 03:10:54

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-13 Thread Jakub Kicinski
On Wed, 13 Mar 2019 07:07:01 +0100, Jiri Pirko wrote: > Tue, Mar 12, 2019 at 09:56:28PM CET, jakub.kicin...@netronome.com wrote: > >On Tue, 12 Mar 2019 15:02:39 +0100, Jiri Pirko wrote: > >> Tue, Mar 12, 2019 at 03:10:54AM CET, wrote: > >> >On Mon, 11 Mar 2019 09:52:04 +0100, Jiri Pirko wrote:

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-13 Thread Samudrala, Sridhar
On 3/13/2019 12:37 AM, Jiri Pirko wrote: Wed, Mar 13, 2019 at 07:17:04AM CET, sridhar.samudr...@intel.com wrote: On 3/12/2019 7:02 AM, Jiri Pirko wrote: I originally planned to implement sriov orchestration api in devlink too. Interesting, would you mind elaborating? I have to think a

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-13 Thread Jiri Pirko
Wed, Mar 13, 2019 at 07:17:04AM CET, sridhar.samudr...@intel.com wrote: > >On 3/12/2019 7:02 AM, Jiri Pirko wrote: > >> >> > >> > > I originally planned to implement sriov orchestration api in devlink too. >> > >> > Interesting, would you mind elaborating? >> >> I have to think about it. But so

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-12 Thread Jiri Pirko
Tue, Mar 12, 2019 at 09:56:28PM CET, jakub.kicin...@netronome.com wrote: >On Tue, 12 Mar 2019 15:02:39 +0100, Jiri Pirko wrote: >> Tue, Mar 12, 2019 at 03:10:54AM CET, wrote: >> >On Mon, 11 Mar 2019 09:52:04 +0100, Jiri Pirko wrote: >> >> Fri, Mar 08, 2019 at 08:09:43PM CET, wrote: >> >> >If th

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-12 Thread Jakub Kicinski
On Tue, 12 Mar 2019 15:02:39 +0100, Jiri Pirko wrote: > Tue, Mar 12, 2019 at 03:10:54AM CET, wrote: > >On Mon, 11 Mar 2019 09:52:04 +0100, Jiri Pirko wrote: > >> Fri, Mar 08, 2019 at 08:09:43PM CET, wrote: > >> >If the switchport is in the hypervisor then only the hypervisor can > >> >control s

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-12 Thread Jiri Pirko
Tue, Mar 12, 2019 at 03:10:54AM CET, jakub.kicin...@netronome.com wrote: >On Mon, 11 Mar 2019 09:52:04 +0100, Jiri Pirko wrote: >> Fri, Mar 08, 2019 at 08:09:43PM CET, jakub.kicin...@netronome.com wrote: >> >If the switchport is in the hypervisor then only the hypervisor can >> >control switching/f

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-11 Thread Jakub Kicinski
On Mon, 11 Mar 2019 09:52:04 +0100, Jiri Pirko wrote: > Fri, Mar 08, 2019 at 08:09:43PM CET, jakub.kicin...@netronome.com wrote: > >If the switchport is in the hypervisor then only the hypervisor can > >control switching/forwarding, correct? > > Correct. > > >The primary use case for partitioni

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-11 Thread Jiri Pirko
Fri, Mar 08, 2019 at 08:09:43PM CET, jakub.kicin...@netronome.com wrote: >On Fri, 8 Mar 2019 15:54:21 +0100, Jiri Pirko wrote: >> Fri, Mar 08, 2019 at 03:52:02AM CET, jakub.kicin...@netronome.com wrote: >> >On Thu, 7 Mar 2019 10:48:16 +0100, Jiri Pirko wrote: >> >> Wed, Mar 06, 2019 at 06:56:38PM

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-08 Thread Jakub Kicinski
On Fri, 8 Mar 2019 15:54:21 +0100, Jiri Pirko wrote: > Fri, Mar 08, 2019 at 03:52:02AM CET, jakub.kicin...@netronome.com wrote: > >On Thu, 7 Mar 2019 10:48:16 +0100, Jiri Pirko wrote: > >> Wed, Mar 06, 2019 at 06:56:38PM CET, jakub.kicin...@netronome.com wrote: > >> >On Wed, 6 Mar 2019 13:20:37

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-08 Thread Jiri Pirko
Fri, Mar 08, 2019 at 03:52:02AM CET, jakub.kicin...@netronome.com wrote: >On Thu, 7 Mar 2019 10:48:16 +0100, Jiri Pirko wrote: >> Wed, Mar 06, 2019 at 06:56:38PM CET, jakub.kicin...@netronome.com wrote: >> >On Wed, 6 Mar 2019 13:20:37 +0100, Jiri Pirko wrote: >> >For creating subdevices, I don't

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-07 Thread Jakub Kicinski
On Thu, 7 Mar 2019 10:48:16 +0100, Jiri Pirko wrote: > Wed, Mar 06, 2019 at 06:56:38PM CET, jakub.kicin...@netronome.com wrote: > >On Wed, 6 Mar 2019 13:20:37 +0100, Jiri Pirko wrote: > >For creating subdevices, I don't think the handle should ever be port. > >We create new ports on a devlink ins

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-07 Thread Jiri Pirko
Wed, Mar 06, 2019 at 06:56:38PM CET, jakub.kicin...@netronome.com wrote: >On Wed, 6 Mar 2019 13:20:37 +0100, Jiri Pirko wrote: >> Tue, Mar 05, 2019 at 06:15:34PM CET, jakub.kicin...@netronome.com wrote: >> >On Tue, 5 Mar 2019 12:06:01 +0100, Jiri Pirko wrote: >> >> >> >as ports. Can we invent a

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-06 Thread Parav Pandit
Hi Jakub, > -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Jakub Kicinski > Sent: Wednesday, March 6, 2019 11:57 AM > To: Jiri Pirko > Cc: da...@davemloft.net; netdev@vger.kernel.org; oss- > driv...@netronome.com > Subject: Re: [PATCH

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-06 Thread Jakub Kicinski
On Wed, 6 Mar 2019 13:20:37 +0100, Jiri Pirko wrote: > Tue, Mar 05, 2019 at 06:15:34PM CET, jakub.kicin...@netronome.com wrote: > >On Tue, 5 Mar 2019 12:06:01 +0100, Jiri Pirko wrote: > >> >> >as ports. Can we invent a new command (say "partition"?) that'd take > >> >> >the bus info where the pa

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-06 Thread Jiri Pirko
Tue, Mar 05, 2019 at 06:15:34PM CET, jakub.kicin...@netronome.com wrote: >On Tue, 5 Mar 2019 12:06:01 +0100, Jiri Pirko wrote: >> >> >as ports. Can we invent a new command (say "partition"?) that'd take >> >> >the bus info where the partition is to be spawned? >> >> >> >> Got it. But the ques

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-05 Thread Parav Pandit
> -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Jakub Kicinski > Sent: Tuesday, March 5, 2019 11:16 AM > To: Jiri Pirko > Cc: da...@davemloft.net; netdev@vger.kernel.org; oss- > driv...@netronome.com > Subject: Re: [PATCH net-nex

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-05 Thread Jakub Kicinski
On Tue, 5 Mar 2019 12:06:01 +0100, Jiri Pirko wrote: > >> >as ports. Can we invent a new command (say "partition"?) that'd take > >> >the bus info where the partition is to be spawned? > >> > >> Got it. But the question is how different this object would be from the > >> existing "port" we ha

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-05 Thread Jiri Pirko
Tue, Mar 05, 2019 at 01:51:59AM CET, jakub.kicin...@netronome.com wrote: >On Mon, 4 Mar 2019 12:08:57 +0100, Jiri Pirko wrote: >> Fri, Mar 01, 2019 at 07:04:50PM CET, jakub.kicin...@netronome.com wrote: >> >PCI endpoint corresponds to a PCI device, but such device >> >can have one more more logical

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-05 Thread Jiri Pirko
Tue, Mar 05, 2019 at 01:40:07AM CET, jakub.kicin...@netronome.com wrote: >On Mon, 4 Mar 2019 12:19:02 +0100, Jiri Pirko wrote: >> Sat, Mar 02, 2019 at 08:48:47PM CET, jakub.kicin...@netronome.com wrote: >> >On Sat, 2 Mar 2019 10:41:16 +0100, Jiri Pirko wrote: >> >> Fri, Mar 01, 2019 at 07:04:50PM

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-05 Thread Jiri Pirko
Tue, Mar 05, 2019 at 01:33:02AM CET, jakub.kicin...@netronome.com wrote: >On Mon, 4 Mar 2019 08:56:09 +0100, Jiri Pirko wrote: >> Sat, Mar 02, 2019 at 08:48:47PM CET, jakub.kicin...@netronome.com wrote: >> >On Sat, 2 Mar 2019 10:41:16 +0100, Jiri Pirko wrote: >> >> Fri, Mar 01, 2019 at 07:04:50PM

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-04 Thread Jakub Kicinski
On Mon, 4 Mar 2019 12:08:57 +0100, Jiri Pirko wrote: > Fri, Mar 01, 2019 at 07:04:50PM CET, jakub.kicin...@netronome.com wrote: > >PCI endpoint corresponds to a PCI device, but such device > >can have one more more logical device ports associated with it. > >We need a way to distinguish those. Add

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-04 Thread Jakub Kicinski
On Mon, 4 Mar 2019 12:19:02 +0100, Jiri Pirko wrote: > Sat, Mar 02, 2019 at 08:48:47PM CET, jakub.kicin...@netronome.com wrote: > >On Sat, 2 Mar 2019 10:41:16 +0100, Jiri Pirko wrote: > >> Fri, Mar 01, 2019 at 07:04:50PM CET, jakub.kicin...@netronome.com wrote: > >> >PCI endpoint corresponds to

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-04 Thread Jakub Kicinski
On Mon, 4 Mar 2019 08:56:09 +0100, Jiri Pirko wrote: > Sat, Mar 02, 2019 at 08:48:47PM CET, jakub.kicin...@netronome.com wrote: > >On Sat, 2 Mar 2019 10:41:16 +0100, Jiri Pirko wrote: > >> Fri, Mar 01, 2019 at 07:04:50PM CET, jakub.kicin...@netronome.com wrote: > >> >PCI endpoint corresponds to

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-04 Thread Jiri Pirko
Sat, Mar 02, 2019 at 08:48:47PM CET, jakub.kicin...@netronome.com wrote: >On Sat, 2 Mar 2019 10:41:16 +0100, Jiri Pirko wrote: >> Fri, Mar 01, 2019 at 07:04:50PM CET, jakub.kicin...@netronome.com wrote: >> >PCI endpoint corresponds to a PCI device, but such device >> >can have one more more logical

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-04 Thread Jiri Pirko
Fri, Mar 01, 2019 at 07:04:50PM CET, jakub.kicin...@netronome.com wrote: >PCI endpoint corresponds to a PCI device, but such device >can have one more more logical device ports associated with it. >We need a way to distinguish those. Add a PCI subport in the >dumps and print the info in phys_port_n

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-04 Thread Jiri Pirko
Sat, Mar 02, 2019 at 08:48:47PM CET, jakub.kicin...@netronome.com wrote: >On Sat, 2 Mar 2019 10:41:16 +0100, Jiri Pirko wrote: >> Fri, Mar 01, 2019 at 07:04:50PM CET, jakub.kicin...@netronome.com wrote: >> >PCI endpoint corresponds to a PCI device, but such device >> >can have one more more logical

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-02 Thread Jakub Kicinski
On Sat, 2 Mar 2019 10:41:16 +0100, Jiri Pirko wrote: > Fri, Mar 01, 2019 at 07:04:50PM CET, jakub.kicin...@netronome.com wrote: > >PCI endpoint corresponds to a PCI device, but such device > >can have one more more logical device ports associated with it. > >We need a way to distinguish those. Add

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-02 Thread Jiri Pirko
Fri, Mar 01, 2019 at 07:04:50PM CET, jakub.kicin...@netronome.com wrote: >PCI endpoint corresponds to a PCI device, but such device >can have one more more logical device ports associated with it. >We need a way to distinguish those. Add a PCI subport in the >dumps and print the info in phys_port_n