RE: [PATCH net-next v2 1/6] qed: Add doorbell overflow recovery mechanism

2018-10-22 Thread Elior, Ariel
> > > +#ifndef writeq > > +#define writeq writeq > > +static inline void writeq(u64 val, void __iomem *reg) > > +{ > > + writel(val & 0x, reg); > > + writel(val >> 32, reg + 0x4UL); > > +} > > +#endif > > Please use the appropriate generic header file to achieve this, do not > reim

Re: [PATCH net-next v2 1/6] qed: Add doorbell overflow recovery mechanism

2018-10-22 Thread David Miller
From: Ariel Elior Date: Mon, 22 Oct 2018 19:40:40 +0300 > > +#ifndef writeq > +#define writeq writeq > +static inline void writeq(u64 val, void __iomem *reg) > +{ > + writel(val & 0x, reg); > + writel(val >> 32, reg + 0x4UL); > +} > +#endif Please use the appropriate generic he