On 04/28/2015 06:44 PM, David Miller wrote:
From: Ivan Vecera
Date: Tue, 28 Apr 2015 16:32:37 +0200
On 04/23/2015 08:31 AM, Sathya Perla wrote:
-Original Message-
From: Ivan Vecera [mailto:ivec...@redhat.com]
The driver unlike other drivers does not log link state changes.
v2: added
From: Ivan Vecera
Date: Tue, 28 Apr 2015 16:32:37 +0200
> On 04/23/2015 08:31 AM, Sathya Perla wrote:
>>> -Original Message-
>>> From: Ivan Vecera [mailto:ivec...@redhat.com]
>>>
>>> The driver unlike other drivers does not log link state changes.
>>>
>>> v2: added current link speed to l
On 04/23/2015 08:31 AM, Sathya Perla wrote:
-Original Message-
From: Ivan Vecera [mailto:ivec...@redhat.com]
The driver unlike other drivers does not log link state changes.
v2: added current link speed to log message
Ivan, I disagree with the v2 change. I think your original intentio
On 04/23/2015 08:31 AM, Sathya Perla wrote:
-Original Message-
From: Ivan Vecera [mailto:ivec...@redhat.com]
The driver unlike other drivers does not log link state changes.
v2: added current link speed to log message
Ivan, I disagree with the v2 change. I think your original intentio
> -Original Message-
> From: Joe Perches [mailto:j...@perches.com]
>
> On Wed, 2015-04-22 at 15:43 +0200, Ivan Vecera wrote:
> > The driver unlike other drivers does not log link state changes.
>
...
>
> Question for the emulex folk:
>
> Is the dom argument to link_status_query necessar
> -Original Message-
> From: Ivan Vecera [mailto:ivec...@redhat.com]
>
> The driver unlike other drivers does not log link state changes.
>
> v2: added current link speed to log message
>
Ivan, I disagree with the v2 change. I think your original intention
was just to log a message when
From: Joe Perches
Date: Wed, 22 Apr 2015 07:07:54 -0700
> On Wed, 2015-04-22 at 15:43 +0200, Ivan Vecera wrote:
>> @@ -658,10 +659,18 @@ void be_link_status_update(struct be_adapter *adapter,
>> u8 link_status)
>> adapter->flags |= BE_FLAGS_LINK_STATUS_INIT;
>> }
>>
>> -i
On 04/22/2015 04:07 PM, Joe Perches wrote:
On Wed, 2015-04-22 at 15:43 +0200, Ivan Vecera wrote:
>The driver unlike other drivers does not log link state changes.
Why add all the speed stuff, why not add a query instead?
I think it'd be simpler to add a line like:
status = be_cmd_link_
On Wed, 2015-04-22 at 15:43 +0200, Ivan Vecera wrote:
> The driver unlike other drivers does not log link state changes.
Why add all the speed stuff, why not add a query instead?
I think it'd be simpler to add a line like:
status = be_cmd_link_status_query(adapter, &speed, &status, 0);
be
