RE: [PATCH net-next 3/5] liquidio CN23XX: Mailbox support

2016-09-13 Thread Vatsavayi, Raghu
nanda; Manlunas, > Felix; Vatsavayi, Raghu > Subject: Re: [PATCH net-next 3/5] liquidio CN23XX: Mailbox support > > From: Raghu Vatsavayi > Date: Fri, 9 Sep 2016 13:08:25 -0700 > > > +int octeon_mbox_read(struct octeon_mbox *mbox) { > > + int ret = 0; > > + unio

Re: [PATCH net-next 3/5] liquidio CN23XX: Mailbox support

2016-09-10 Thread David Miller
From: Raghu Vatsavayi Date: Fri, 9 Sep 2016 13:08:25 -0700 > +int octeon_mbox_read(struct octeon_mbox *mbox) > +{ > + int ret = 0; > + union octeon_mbox_message msg; > + Please always order local variable declarations from longest to shortest line. Please audit your entire submission fo