On Wed, 2017-06-14 at 23:45 +, YUAN Linyu wrote:
> >
> > But still a few more, I think that you didn't find, e.g.
> > in mac80211.
>
> Yes, I thought you already done in mac80211
So did I, but I also only applied my spatch :)
johannes
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org]
> On Behalf Of Johannes Berg
> Sent: Thursday, June 15, 2017 12:32 AM
> To: cug...@163.com; netdev@vger.kernel.org
> Cc: David S . Miller; YUAN Linyu
> Subject: Re:
From: Johannes Berg
Date: Wed, 14 Jun 2017 22:11:54 +0200
> On Wed, 2017-06-14 at 15:38 -0400, David Miller wrote:
>
>> What do you think about Stephen Hemminger's feedback to make
>> skb_put_zero() return "void *". It will avoid a lot of casts and
>> make the conversions look nicer.
>
> I thi
On Wed, 2017-06-14 at 15:38 -0400, David Miller wrote:
> What do you think about Stephen Hemminger's feedback to make
> skb_put_zero() return "void *". It will avoid a lot of casts and
> make the conversions look nicer.
I think it's a good idea. I can send a patch, and remove some casts
where th
From: Johannes Berg
Date: Wed, 14 Jun 2017 18:31:48 +0200
> On Wed, 2017-06-14 at 18:29 +0200, Johannes Berg wrote:
>> On Wed, 2017-06-14 at 23:00 +0800, yuan linyu wrote:
>>
>> > sorry, I do them by hand.
>>
>> oh, ok.
>>
>> This seems to work:
>>
>> @@
>> identifier p;
>> expression len;
>
On Wed, 2017-06-14 at 18:29 +0200, Johannes Berg wrote:
> On Wed, 2017-06-14 at 23:00 +0800, yuan linyu wrote:
>
> > sorry, I do them by hand.
>
> oh, ok.
>
> This seems to work:
>
> @@
> identifier p;
> expression len;
> expression skb;
> type t;
> @@
> -p = (t)skb_put(skb, len);
> -memset(p,
On Wed, 2017-06-14 at 23:00 +0800, yuan linyu wrote:
> sorry, I do them by hand.
oh, ok.
This seems to work:
@@
identifier p;
expression len;
expression skb;
type t;
@@
-p = (t)skb_put(skb, len);
-memset(p, 0, len);
+p = (t)skb_put_zero(skb, len);
johannes
On 三, 2017-06-14 at 16:42 +0200, Johannes Berg wrote:
> On Wed, 2017-06-14 at 22:30 +0800, yuan linyu wrote:
> >
> > From: yuan linyu
> >
> >
> > yuan linyu (11):
> > ipv6: skb_put_zero() used to optimize code
> > ipv4: skb_put_zero() used to optimize code
> > ncsi: skb_put_zero() used to
On Wed, 2017-06-14 at 22:30 +0800, yuan linyu wrote:
> From: yuan linyu
>
>
> yuan linyu (11):
> ipv6: skb_put_zero() used to optimize code
> ipv4: skb_put_zero() used to optimize code
> ncsi: skb_put_zero() used to optimize code
> dsa: skb_put_zero() used to optimize code
> key: skb_p
