RE: [PATCH net-next] skbuff: Add BUG_ON in skb_init.

2017-08-09 Thread Yuan, Linyu (NSB - CN/Shanghai)
ng > Sent: Thursday, August 10, 2017 2:10 PM > To: David Miller > Cc: Linux Kernel Network Developers > Subject: Re: [PATCH net-next] skbuff: Add BUG_ON in skb_init. > > Thanks a lot. I found it when reviewing this codes. and BUG_ON is > added in the init_inodecache(). We ma

Re: [PATCH net-next] skbuff: Add BUG_ON in skb_init.

2017-08-09 Thread Tonghao Zhang
Thanks a lot. I found it when reviewing this codes. and BUG_ON is added in the init_inodecache(). We may remove it or not ? diff --git a/net/socket.c b/net/socket.c index b332d1e..ebee3ee 100644 --- a/net/socket.c +++ b/net/socket.c @@ -296,7 +296,6 @@ static void init_inodecache(void)

Re: [PATCH net-next] skbuff: Add BUG_ON in skb_init.

2017-08-09 Thread David Miller
From: Tonghao Zhang Date: Wed, 9 Aug 2017 05:04:38 -0700 > When initializing the skbuff SLAB cache, we should make > sure it is successful. Adding BUG_ON to check it and > init_inodecache() is in the same case. > > Signed-off-by: Tonghao Zhang > --- > net/core/skbuff.c | 2 ++ > 1 file change