Re: [PATCH net-next] net: x25: Remove unimplemented X.25-over-LLC code stubs

2020-12-12 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 8 Dec 2020 19:33:46 -0800 you wrote: > According to the X.25 documentation, there was a plan to implement > X.25-over-802.2-LLC. It never finished but left various code stubs in the > X.25 code. At this time it is

RE: [PATCH net-next] net: x25: Remove unimplemented X.25-over-LLC code stubs

2020-12-10 Thread David Laight
From: Xie He > Sent: 10 December 2020 10:17 > > On Thu, Dec 10, 2020 at 1:14 AM David Laight wrote: > > > > > To me, LLC1 and LLC2 are to Ethernet what UDP and TCP are to IP > > > networks. I think we can use LLC1 and LLC2 wherever UDP and TCP can be > > > used, as long as we are in the same LAN

Re: [PATCH net-next] net: x25: Remove unimplemented X.25-over-LLC code stubs

2020-12-10 Thread Xie He
On Thu, Dec 10, 2020 at 1:14 AM David Laight wrote: > > > To me, LLC1 and LLC2 are to Ethernet what UDP and TCP are to IP > > networks. I think we can use LLC1 and LLC2 wherever UDP and TCP can be > > used, as long as we are in the same LAN and are willing to use MAC > > addresses as the addresses

RE: [PATCH net-next] net: x25: Remove unimplemented X.25-over-LLC code stubs

2020-12-10 Thread David Laight
From: Xie He > Sent: 09 December 2020 22:54 > > On Wed, Dec 9, 2020 at 1:21 PM David Laight wrote: > > > > I always wondered about running Class 2 transport directly over LLC2 > > (rather than Class 4 over LLC1). > > But the only LLC2 user was netbios - and microsoft's LLC2 was broken. > > Not to

Re: [PATCH net-next] net: x25: Remove unimplemented X.25-over-LLC code stubs

2020-12-09 Thread Xie He
On Wed, Dec 9, 2020 at 1:21 PM David Laight wrote: > > I always wondered about running Class 2 transport directly over LLC2 > (rather than Class 4 over LLC1). > But the only LLC2 user was netbios - and microsoft's LLC2 was broken. > Not to mention the window probing needed to handle systems that >

RE: [PATCH net-next] net: x25: Remove unimplemented X.25-over-LLC code stubs

2020-12-09 Thread David Laight
From: Xie He > Sent: 09 December 2020 03:34 > > According to the X.25 documentation, there was a plan to implement > X.25-over-802.2-LLC. It never finished but left various code stubs in the > X.25 code. At this time it is unlikely that it would ever finish so it > may be better to remove those co