Re: [PATCH net-next] mlx5: Add MLX5_SET64_VCHK to fix BUILD_BUG_ON

2016-10-11 Thread Saeed Mahameed
On Wed, Oct 12, 2016 at 4:40 AM, Leon Romanovsky wrote: > On Tue, Oct 11, 2016 at 08:46:45AM -0700, Tom Herbert wrote: >> On Tue, Oct 11, 2016 at 4:57 AM, Saeed Mahameed >> wrote: >> > On Tue, Oct 11, 2016 at 7:50 PM, David Laight >> > wrote: >> >> From: Tom Herbert >> >>> Sent: 11 October 2016

Re: [PATCH net-next] mlx5: Add MLX5_SET64_VCHK to fix BUILD_BUG_ON

2016-10-11 Thread Saeed Mahameed
On 10/11/2016 01:22 PM, Tom Herbert wrote: I am hitting this in mlx5: drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c: In function ‘reclaim_pages_cmd.clone.0’: drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c:346: error: call to ‘__compiletime_assert_346’ declared with attribute error:

Re: [PATCH net-next] mlx5: Add MLX5_SET64_VCHK to fix BUILD_BUG_ON

2016-10-11 Thread Leon Romanovsky
On Tue, Oct 11, 2016 at 08:46:45AM -0700, Tom Herbert wrote: > On Tue, Oct 11, 2016 at 4:57 AM, Saeed Mahameed > wrote: > > On Tue, Oct 11, 2016 at 7:50 PM, David Laight > > wrote: > >> From: Tom Herbert > >>> Sent: 11 October 2016 05:22 > >> ... > >>> Fix is to create MLX5_SET64_VCHK that takes

Re: [PATCH net-next] mlx5: Add MLX5_SET64_VCHK to fix BUILD_BUG_ON

2016-10-11 Thread Tom Herbert
On Tue, Oct 11, 2016 at 4:57 AM, Saeed Mahameed wrote: > On Tue, Oct 11, 2016 at 7:50 PM, David Laight wrote: >> From: Tom Herbert >>> Sent: 11 October 2016 05:22 >> ... >>> Fix is to create MLX5_SET64_VCHK that takes an additional argument >>> that is a constant. There are two callers of MLX5_SE

Re: [PATCH net-next] mlx5: Add MLX5_SET64_VCHK to fix BUILD_BUG_ON

2016-10-11 Thread Saeed Mahameed
On Tue, Oct 11, 2016 at 7:50 PM, David Laight wrote: > From: Tom Herbert >> Sent: 11 October 2016 05:22 > ... >> Fix is to create MLX5_SET64_VCHK that takes an additional argument >> that is a constant. There are two callers of MLX5_SET64 that are >> trying to get a variable offset, change those t

RE: [PATCH net-next] mlx5: Add MLX5_SET64_VCHK to fix BUILD_BUG_ON

2016-10-11 Thread David Laight
From: Tom Herbert > Sent: 11 October 2016 05:22 ... > Fix is to create MLX5_SET64_VCHK that takes an additional argument > that is a constant. There are two callers of MLX5_SET64 that are > trying to get a variable offset, change those to call MLX5_SET64_VCHK > passing pas[0] as the argument to use