Hi Florian,
> It still is completely unnecessary, you can do something like the following:
>
> struct phy_device *phydev = netdev->phydev;
>
> phy_disconnect(phydev);
> if (phy_is_pseudo_fixed_link(phydev))
> fixed_phy_unregister(phydev);
>
> while netdev->phydev
On 04/25/2018 10:04 AM, raghuramchary.jallipa...@microchip.com wrote:
> Hi Andrew,
>>> dev->fixedphy stores the fixed phydev, which will be passed to the
>>> fixed_phy_unregister routine , so I think phy_is_pseudo_fixed_link check
>> is not necessary.
>>
>> I'm saying you can get rid of dev->f
Hi Andrew,
> > >
> > dev->fixedphy stores the fixed phydev, which will be passed to the
> > fixed_phy_unregister routine , so I think phy_is_pseudo_fixed_link check
> is not necessary.
>
> I'm saying you can get rid of dev->fixedphy, and just use
> netdev->phydev, and phy_is_pseudo_fixed_link(netd
> OK. Will modify to netdev_dbg()
>
> > > + dev->interface = PHY_INTERFACE_MODE_RGMII;
> > > + dev->fixedphy = phydev;
> >
> > You can use
> >
> > if (!phy_is_pseudo_fixed_link(phydev))
> >
> > to determine is a PHY is a fixed phy. I think you can then do withou
Hi Andrew,
> > +#define DRIVER_VERSION "1.0.7"
>
> Hi Raghuram
>
> Driver version strings a pretty pointless. You might want to remove it.
>
OK, will remove it.
> > + netdev_info(dev->net, "Registered FIXED PHY\n");
>
> There are too many detdev_info() messages here. May
> #define DRIVER_AUTHOR"WOOJUNG HUH "
> #define DRIVER_DESC "LAN78XX USB 3.0 Gigabit Ethernet Devices"
> #define DRIVER_NAME "lan78xx"
> -#define DRIVER_VERSION "1.0.6"
> +#define DRIVER_VERSION "1.0.7"
Hi Raghuram
Driver version strings a pretty pointless. You might want
