Re: [PATCH net-next] devlink: let kernel allocate region snapshot id

2020-04-29 Thread Jiri Pirko
Wed, Apr 29, 2020 at 06:35:18PM CEST, k...@kernel.org wrote: >On Wed, 29 Apr 2020 07:45:52 +0200 Jiri Pirko wrote: >> Wed, Apr 29, 2020 at 03:42:48AM CEST, k...@kernel.org wrote: >> >Jiri, this is what I had in mind of snapshots and the same >> >thing will come back for slice allocation. >> >> O

RE: [PATCH net-next] devlink: let kernel allocate region snapshot id

2020-04-29 Thread Keller, Jacob E
> -Original Message- > From: Jakub Kicinski > Sent: Wednesday, April 29, 2020 9:39 AM > To: Keller, Jacob E > Cc: Jiri Pirko ; da...@davemloft.net; > netdev@vger.kernel.org; > kernel-t...@fb.com > Subject: Re: [PATCH net-next] devlink: let kernel allocate re

Re: [PATCH net-next] devlink: let kernel allocate region snapshot id

2020-04-29 Thread Jakub Kicinski
On Wed, 29 Apr 2020 15:34:30 + Keller, Jacob E wrote: > > How the output is going to looks like it this or any of the follow-up > > calls in this function are going to fail? > > > > I guess it is going to be handled gracefully in the userspace app, > > right? > > I'm wondering what the issue i

Re: [PATCH net-next] devlink: let kernel allocate region snapshot id

2020-04-29 Thread Jakub Kicinski
On Wed, 29 Apr 2020 07:45:52 +0200 Jiri Pirko wrote: > Wed, Apr 29, 2020 at 03:42:48AM CEST, k...@kernel.org wrote: > >Jiri, this is what I had in mind of snapshots and the same > >thing will come back for slice allocation. > > Okay. Could you please send the userspace patch too in order to see

RE: [PATCH net-next] devlink: let kernel allocate region snapshot id

2020-04-29 Thread Keller, Jacob E
> -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Jiri Pirko > Sent: Tuesday, April 28, 2020 10:46 PM > To: Jakub Kicinski > Cc: da...@davemloft.net; netdev@vger.kernel.org; kernel-t...@fb.com; > Keller, Jacob E > Subject: Re: [PATC

Re: [PATCH net-next] devlink: let kernel allocate region snapshot id

2020-04-28 Thread Jiri Pirko
Wed, Apr 29, 2020 at 03:42:48AM CEST, k...@kernel.org wrote: >Currently users have to choose a free snapshot id before >calling DEVLINK_CMD_REGION_NEW. This is potentially racy >and inconvenient. > >Make the DEVLINK_ATTR_REGION_SNAPSHOT_ID optional and try >to allocate id automatically. Send a mess