On Fri, Aug 28, 2020 at 02:24:28PM +, Asmaa Mnebhi wrote:
> > > + The second generation BlueField SoC from Mellanox Technologies
> > > + supports an out-of-band Gigabit Ethernet management port to the
> > > + Arm subsystem.
> >
> > You might want to additionally select the PHY driver you
> > +static int mlxbf_gige_get_link_ksettings(struct net_device *netdev,
> > +struct ethtool_link_ksettings
> *link_ksettings) {
> > + struct phy_device *phydev = netdev->phydev;
> > + u32 supported, advertising;
> phy_ethtool_ksettings_get() and maybe phy_e
> > + The second generation BlueField SoC from Mellanox Technologies
> > + supports an out-of-band Gigabit Ethernet management port to the
> > + Arm subsystem.
>
> You might want to additionally select the PHY driver you are using.
>
It is preferable to not set a specific PHY driver h
Hi Asmaa
Please wrap your emails at about 75 characters.
> So let me explain further and would greatly appreciate your input.
> Technically, when this driver gets loaded, we shouldn't need the interrupt
> when bringing up the link for the first time, do we?
> Correct me if I am wrong, "phy_star
> -Original Message-
> From: Andrew Lunn
> Sent: Tuesday, August 11, 2020 4:07 PM
> To: Asmaa Mnebhi
> Cc: David Thompson ;
> netdev@vger.kernel.org; da...@davemloft.net; k...@kernel.org; Jiri
> Pirko ; Asmaa Mnebhi
> Subject: Re: [PATCH net-next] Add Me
On Tue, Aug 11, 2020 at 07:53:35PM +, Asmaa Mnebhi wrote:
> Hi Andrew,
>
> Thanks again for your feedback.
>
> > > + /* Finally check if this interrupt is from PHY device.
> > > + * Return if it is not.
> > > + */
> > > + val = readl(priv->gpio_io +
> > > + MLXBF_GIGE_GPIO_C
Hi Andrew,
Thanks again for your feedback.
> > + /* Finally check if this interrupt is from PHY device.
> > +* Return if it is not.
> > +*/
> > + val = readl(priv->gpio_io +
> > + MLXBF_GIGE_GPIO_CAUSE_OR_CAUSE_EVTEN0);
> > + if (!(val & priv->phy_int_gpio_mask))
>
> -Original Message-
> From: Andrew Lunn
> Sent: Friday, July 31, 2020 9:15 PM
> To: Asmaa Mnebhi
> Cc: David Thompson ;
> netdev@vger.kernel.org; da...@davemloft.net; k...@kernel.org; Jiri Pirko
>
> Subject: Re: [PATCH net-next] Add Mellanox BlueField
> > > > +static int mlxbf_gige_mdio_read(struct mii_bus *bus, int phy_add,
> > > > +int
> > >
> > > > +phy_reg) {
> > >
> > > > + struct mlxbf_gige *priv = bus->priv;
> > >
> > > > + u32 cmd;
> > >
> > > > + u32 ret;
> > >
> > > > +
> > >
> > > > + /* If the lock is
> -Original Message-
> From: Andrew Lunn
> Sent: Friday, July 31, 2020 3:55 PM
> To: Asmaa Mnebhi
> Cc: David Thompson ;
> netdev@vger.kernel.org; da...@davemloft.net; k...@kernel.org; Jiri
> Pirko
> Subject: Re: [PATCH net-next] Add Mellanox BlueField G
On Fri, Jul 31, 2020 at 06:54:04PM +, Asmaa Mnebhi wrote:
Hi Asmaa
Please don't send HTML obfusticated emails to mailing lists.
> > +static int mlxbf_gige_mdio_read(struct mii_bus *bus, int phy_add, int
>
> > +phy_reg) {
>
> > + struct mlxbf_gige *priv = bus->priv;
>
> > +
> +static int mlxbf_gige_mdio_read(struct mii_bus *bus, int phy_add, int
> phy_reg)
> +{
> + struct mlxbf_gige *priv = bus->priv;
> + u32 cmd;
> + u32 ret;
Here and in write, please check if it is a C45 transaction request and
return -EOPNOTSUPP.
Andrew
> +config MLXBF_GIGE
> + tristate "Mellanox Technologies BlueField Gigabit Ethernet support"
> + depends on (ARM64 || COMPILE_TEST) && ACPI && INET
> + select PHYLIB
> + help
> + The second generation BlueField SoC from Mellanox Technologies
> + supports an out-of-band G
On Wed, Jul 29, 2020 at 02:29:15PM -0400, David Thompson wrote:
Hi David
> +static void mlxbf_gige_get_pauseparam(struct net_device *netdev,
> + struct ethtool_pauseparam *pause)
> +{
> + pause->autoneg = AUTONEG_ENABLE;
> + pause->rx_pause = 1;
> + p
Hi David
>> +static int mlxbf_gige_mdio_poll_bit(struct mlxbf_gige *priv, u32 bit_mask)
> +{
> + unsigned long timeout;
> + u32 val;
> +
> + timeout = jiffies + msecs_to_jiffies(MLXBF_GIGE_MDIO_POLL_BUSY_TIMEOUT);
> + do {
> + val = readl(priv->mdio_io + MLXBF_GIGE_MDIO
Hi David,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/David-Thompson/Add-Mellanox-BlueField-Gigabit-Ethernet-driver/20200730-023011
base: https://git.kernel.org/pub/scm/linux/kernel/git/da
On Wed, 29 Jul 2020 14:29:15 -0400 David Thompson wrote:
> This patch adds build and driver logic for the "mlxbf_gige"
> Ethernet driver from Mellanox Technologies.
Please fix these W=1 C=1 warnings:
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:256:29: warning:
Using plain integer
From: David Thompson
Date: Wed, 29 Jul 2020 19:41:30 +
> It's been pointed out to me that this section is incomplete, and I apologize.
...
David, do you have any idea what kind of burdon you create by quoting
an entire HUGE patch just to add some commentary to a small portion?
Take a look
> -Original Message-
> From: David Thompson
> Sent: Wednesday, July 29, 2020 2:29 PM
> To: netdev@vger.kernel.org
> Cc: da...@davemloft.net; k...@kernel.org; Jiri Pirko ;
> David Thompson ; Asmaa Mnebhi
>
> Subject: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver
>
> T
19 matches
Mail list logo
