Re: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors

2016-11-30 Thread Michael S. Tsirkin
-ker...@vger.kernel.org; caihe > >Subject: Re: [PATCH net] vhost_net: don't continue to call the recvmsg when > >meet errors > > > > > > > >On 2016年12月01日 11:27, Michael S. Tsirkin wrote: > >> On Thu, Dec 01, 2016 at 11:26:21AM +0800, Jason W

RE: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors

2016-11-30 Thread wangyunjian
mber 30, 2016 9:41 PM >>>>>> > > > >To: wangyunjian >>>>>> > > > >Cc:jasow...@redhat.com;netdev@vger.kernel.org;linux-kernel@ >>>>>> > > > >vger.kernel.org; caihe >>>>>> > >

Re: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors

2016-11-30 Thread Jason Wang
> > >From: Michael S. Tsirkin [mailto:m...@redhat.com] > > > >Sent: Wednesday, November 30, 2016 9:41 PM > > > >To: wangyunjian > > > >Cc:jasow...@redhat.com;netdev@vger.kernel.org;linux-ker...@vger.kernel.org; caihe > > > >S

Re: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors

2016-11-30 Thread Michael S. Tsirkin
...@redhat.com] > > > > Sent: Wednesday, November 30, 2016 9:41 PM > > > > To: wangyunjian > > > > Cc: jasow...@redhat.com; netdev@vger.kernel.org; > > > > linux-ker...@vger.kernel.org; caihe > > > > Subject: Re: [PATCH net] vhost_net: do

Re: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors

2016-11-30 Thread Jason Wang
; linux-ker...@vger.kernel.org; caihe Subject: Re: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors On Wed, Nov 30, 2016 at 08:10:57PM +0800, Yunjian Wang wrote: When we meet an error(err=-EBADFD) recvmsg, How do you get EBADFD? Won't vhost_net_rx_peek_head_le

Re: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors

2016-11-30 Thread Michael S. Tsirkin
> >linux-ker...@vger.kernel.org; caihe > >Subject: Re: [PATCH net] vhost_net: don't continue to call the recvmsg when > >meet errors > > > >On Wed, Nov 30, 2016 at 08:10:57PM +0800, Yunjian Wang wrote: > >> When we meet an error(err=-EBADFD) recvmsg,

Re: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors

2016-11-30 Thread Jason Wang
On 2016年11月30日 21:40, Michael S. Tsirkin wrote: On Wed, Nov 30, 2016 at 08:10:57PM +0800, Yunjian Wang wrote: When we meet an error(err=-EBADFD) recvmsg, How do you get EBADFD? Won't vhost_net_rx_peek_head_len return 0 in this case, breaking the loop? the error handling in vhost handle_rx()

Re: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors

2016-11-30 Thread Jason Wang
] vhost_net: don't continue to call the recvmsg when meet errors On Wed, Nov 30, 2016 at 08:10:57PM +0800, Yunjian Wang wrote: When we meet an error(err=-EBADFD) recvmsg, How do you get EBADFD? Won't vhost_net_rx_peek_head_len return 0 in this case, breaking the loop? We started many guest

RE: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors

2016-11-30 Thread wangyunjian
>-Original Message- >From: Michael S. Tsirkin [mailto:m...@redhat.com] >Sent: Wednesday, November 30, 2016 9:41 PM >To: wangyunjian >Cc: jasow...@redhat.com; netdev@vger.kernel.org; linux-ker...@vger.kernel.org; >caihe >Subject: Re: [PATCH net] vhost_net: don&#

Re: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors

2016-11-30 Thread Michael S. Tsirkin
On Wed, Nov 30, 2016 at 09:07:16PM +0800, Jason Wang wrote: > > > On 2016年11月30日 20:10, Yunjian Wang wrote: > > When we meet an error(err=-EBADFD) recvmsg, the error handling in vhost > > handle_rx() will continue. This will cause a soft CPU lockup in vhost > > thread. > > > > Signed-off-by: Yu

Re: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors

2016-11-30 Thread Michael S. Tsirkin
On Wed, Nov 30, 2016 at 08:10:57PM +0800, Yunjian Wang wrote: > When we meet an error(err=-EBADFD) recvmsg, How do you get EBADFD? Won't vhost_net_rx_peek_head_len return 0 in this case, breaking the loop? > the error handling in vhost > handle_rx() will continue. This will cause a soft CPU locku

Re: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors

2016-11-30 Thread Jason Wang
On 2016年11月30日 20:10, Yunjian Wang wrote: When we meet an error(err=-EBADFD) recvmsg, the error handling in vhost handle_rx() will continue. This will cause a soft CPU lockup in vhost thread. Signed-off-by: Yunjian Wang --- drivers/vhost/net.c | 3 +++ 1 file changed, 3 insertions(+) diff