From: Eric Dumazet
Date: Wed, 2 May 2018 20:25:13 -0700
> When adding rb-tree for TCP retransmit queue, we inadvertently broke
> TCP autocorking.
>
> tcp_should_autocork() should really check if the rtx queue is not empty.
>
> Tested:
...
> Fixes: 75c119afe14f ("tcp: implement rb-tree based r
On Wed, May 2, 2018 at 11:25 PM, Eric Dumazet wrote:
> Fixes: 75c119afe14f ("tcp: implement rb-tree based retransmit queue")
> Signed-off-by: Eric Dumazet
> Reported-by: Michael Wenig
> Tested-by: Michael Wenig
Acked-by: Soheil Hassas Yeganeh
Thank you for catching and fixing this!
On Wed, May 2, 2018 at 11:25 PM Eric Dumazet wrote:
> When adding rb-tree for TCP retransmit queue, we inadvertently broke
> TCP autocorking.
> tcp_should_autocork() should really check if the rtx queue is not empty.
...
> Fixes: 75c119afe14f ("tcp: implement rb-tree based retransmit queue")
>
Thank you, Eric, for fixing this!
Michael
-Original Message-
From: Eric Dumazet [mailto:eduma...@google.com]
Sent: Wednesday, May 2, 2018 8:25 PM
To: David S . Miller
Cc: netdev ; Eric Dumazet ;
Michael Wenig ; Eric Dumazet
Subject: [PATCH net] tcp: restore autocorking
When adding r
On Thu, May 3, 2018 at 4:06 AM Tariq Toukan wrote:
> On 03/05/2018 6:25 AM, Eric Dumazet wrote:
> > When adding rb-tree for TCP retransmit queue, we inadvertently broke
> > TCP autocorking.
> >
> > tcp_should_autocork() should really check if the rtx queue is not empty.
> >
> Hi Eric,
> We ar
On 03/05/2018 6:25 AM, Eric Dumazet wrote:
When adding rb-tree for TCP retransmit queue, we inadvertently broke
TCP autocorking.
tcp_should_autocork() should really check if the rtx queue is not empty.
Hi Eric,
We are glad to see that the issue that Tal investigated and reported [1]
is no
