RE: [PATCH linux-can-next/flexcan] can: flexcan: fix TDC feature

2020-09-15 Thread Joakim Zhang
> -Original Message- > From: Marc Kleine-Budde > Sent: 2020年9月16日 6:16 > To: Joakim Zhang ; Michael Walle > > Cc: linux-...@vger.kernel.org; dl-linux-imx ; > netdev@vger.kernel.org > Subject: Re: [PATCH linux-can-next/flexcan] can: flexcan: fix TDC feature

Re: [PATCH linux-can-next/flexcan] can: flexcan: fix TDC feature

2020-09-15 Thread Marc Kleine-Budde
On 6/30/20 4:25 AM, Joakim Zhang wrote: > I have also noticed this difference, although this could not break function, > but IMO, using priv->can.ctrlmode should be better. > > Some nitpicks: > > 1) Can we use uniform check for HW which supports CAN FD in the driver, using > priv->can.ctrlmode_sup

Re: [PATCH linux-can-next/flexcan] can: flexcan: fix TDC feature

2020-09-15 Thread Marc Kleine-Budde
On 6/29/20 6:23 PM, Michael Walle wrote: > Hi Marc, > >> I've cleaned up the patches a bit, can you test this branch: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/log/?h=flexcan > > This is working, but as Joakim already said, CAN-FD ISO mode is missing. > It defau

Re: [PATCH linux-can-next/flexcan] can: flexcan: fix TDC feature

2020-09-14 Thread Michael Walle
Hi Marc, Am 2020-07-23 23:09, schrieb Michael Walle: Am 2020-06-25 14:56, schrieb Marc Kleine-Budde: On 6/25/20 2:37 PM, Michael Walle wrote: Am 2020-06-02 12:15, schrieb Michael Walle: Hi Marc, Am 2020-04-16 11:41, schrieb Joakim Zhang: Hi Marc, How about FlexCAN FD patch set, it is pendi

Re: [PATCH linux-can-next/flexcan] can: flexcan: fix TDC feature

2020-07-23 Thread Michael Walle
Am 2020-06-25 14:56, schrieb Marc Kleine-Budde: On 6/25/20 2:37 PM, Michael Walle wrote: Am 2020-06-02 12:15, schrieb Michael Walle: Hi Marc, Am 2020-04-16 11:41, schrieb Joakim Zhang: Hi Marc, How about FlexCAN FD patch set, it is pending for a long time. Many work would base on it, we are

RE: [PATCH linux-can-next/flexcan] can: flexcan: fix TDC feature

2020-06-29 Thread Joakim Zhang
> -Original Message- > From: Michael Walle > Sent: 2020年6月30日 0:23 > To: Marc Kleine-Budde > Cc: Joakim Zhang ; linux-...@vger.kernel.org; > dl-linux-imx ; netdev@vger.kernel.org > Subject: Re: [PATCH linux-can-next/flexcan] can: flexcan: fix TDC feature >

RE: [PATCH linux-can-next/flexcan] can: flexcan: fix TDC feature

2020-06-29 Thread Joakim Zhang
> -Original Message- > From: Marc Kleine-Budde > Sent: 2020年6月25日 20:57 > To: Michael Walle ; Joakim Zhang > > Cc: linux-...@vger.kernel.org; dl-linux-imx ; > netdev@vger.kernel.org > Subject: Re: [PATCH linux-can-next/flexcan] can: flexcan: fix TDC feature

Re: [PATCH linux-can-next/flexcan] can: flexcan: fix TDC feature

2020-06-29 Thread Michael Walle
Hi Marc, I've cleaned up the patches a bit, can you test this branch: https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/log/?h=flexcan This is working, but as Joakim already said, CAN-FD ISO mode is missing. It defaults to non-ISO mode, which is even worse, IMHO. But I'v

Re: [PATCH linux-can-next/flexcan] can: flexcan: fix TDC feature

2020-06-25 Thread Marc Kleine-Budde
On 6/25/20 2:37 PM, Michael Walle wrote: > Am 2020-06-02 12:15, schrieb Michael Walle: >> Hi Marc, >> >> Am 2020-04-16 11:41, schrieb Joakim Zhang: >>> Hi Marc, >>> >>> How about FlexCAN FD patch set, it is pending for a long time. Many >>> work would base on it, we are happy to see it in upstream

Re: [PATCH linux-can-next/flexcan] can: flexcan: fix TDC feature

2020-06-25 Thread Michael Walle
Am 2020-06-02 12:15, schrieb Michael Walle: Hi Marc, Am 2020-04-16 11:41, schrieb Joakim Zhang: Hi Marc, How about FlexCAN FD patch set, it is pending for a long time. Many work would base on it, we are happy to see it in upstream mainline ASAP. Michael Walle also gives out the test-by tag:

Re: [PATCH linux-can-next/flexcan] can: flexcan: fix TDC feature

2020-06-02 Thread Michael Walle
Hi Marc, Am 2020-04-16 11:41, schrieb Joakim Zhang: Hi Marc, How about FlexCAN FD patch set, it is pending for a long time. Many work would base on it, we are happy to see it in upstream mainline ASAP. Michael Walle also gives out the test-by tag: Tested-by: Michael Walle There seem