Re: [PATCH bpf-next] xsk: build skb by page

2021-01-19 Thread Alexander Lobakin
From: Xuan Zhuo Date: Sat, 16 Jan 2021 10:44:53 +0800 > This patch is used to construct skb based on page to save memory copy > overhead. > > This has one problem: > > We construct the skb by fill the data page as a frag into the skb. In > this way, the linear space is empty, and the header inf

Re: [PATCH bpf-next] xsk: build skb by page

2021-01-18 Thread Magnus Karlsson
On Mon, Jan 18, 2021 at 5:38 PM Alexander Lobakin wrote: > > > From: Magnus Karlsson > > Date: Mon, 18 Jan 2021 16:10:40 +0100 > > > > On Mon, Jan 18, 2021 at 3:47 PM Alexander Lobakin wrote: > > > > > > From: Alexander Lobakin > > > Date: Mon, 18 Jan 2021 13:00:17 + > > > > > > > From: Yun

Re: [PATCH bpf-next] xsk: build skb by page

2021-01-18 Thread Magnus Karlsson
On Mon, Jan 18, 2021 at 3:47 PM Alexander Lobakin wrote: > > From: Alexander Lobakin > Date: Mon, 18 Jan 2021 13:00:17 + > > > From: Yunsheng Lin > > Date: Mon, 18 Jan 2021 20:40:52 +0800 > > > >> On 2021/1/16 10:44, Xuan Zhuo wrote: > >>> This patch is used to construct skb based on page to

Re: [PATCH bpf-next] xsk: build skb by page

2021-01-18 Thread Alexander Lobakin
> From: Magnus Karlsson > Date: Mon, 18 Jan 2021 16:10:40 +0100 > > On Mon, Jan 18, 2021 at 3:47 PM Alexander Lobakin wrote: > > > > From: Alexander Lobakin > > Date: Mon, 18 Jan 2021 13:00:17 + > > > > > From: Yunsheng Lin > > > Date: Mon, 18 Jan 2021 20:40:52 +0800 > > > > > >> On 2021/1

Re: [PATCH bpf-next] xsk: build skb by page

2021-01-18 Thread Magnus Karlsson
On Mon, Jan 18, 2021 at 3:47 PM Alexander Lobakin wrote: > > From: Alexander Lobakin > Date: Mon, 18 Jan 2021 13:00:17 + > > > From: Yunsheng Lin > > Date: Mon, 18 Jan 2021 20:40:52 +0800 > > > >> On 2021/1/16 10:44, Xuan Zhuo wrote: > >>> This patch is used to construct skb based on page to

Re: [PATCH bpf-next] xsk: build skb by page

2021-01-18 Thread Alexander Lobakin
From: Alexander Lobakin Date: Mon, 18 Jan 2021 13:00:17 + > From: Yunsheng Lin > Date: Mon, 18 Jan 2021 20:40:52 +0800 > >> On 2021/1/16 10:44, Xuan Zhuo wrote: >>> This patch is used to construct skb based on page to save memory copy >>> overhead. >>> >>> This has one problem: >>> >>> We co

Re: [PATCH bpf-next] xsk: build skb by page

2021-01-18 Thread Alexander Lobakin
From: Yunsheng Lin Date: Mon, 18 Jan 2021 20:40:52 +0800 > On 2021/1/16 10:44, Xuan Zhuo wrote: >> This patch is used to construct skb based on page to save memory copy >> overhead. >> >> This has one problem: >> >> We construct the skb by fill the data page as a frag into the skb. In >> this way

Re: [PATCH bpf-next] xsk: build skb by page

2021-01-18 Thread Alexander Lobakin
From: Xuan Zhuo Date: Sat, 16 Jan 2021 10:44:53 +0800 > This patch is used to construct skb based on page to save memory copy > overhead. > > This has one problem: > > We construct the skb by fill the data page as a frag into the skb. In > this way, the linear space is empty, and the header inf

Re: [PATCH bpf-next] xsk: build skb by page

2021-01-18 Thread Yunsheng Lin
On 2021/1/16 10:44, Xuan Zhuo wrote: > This patch is used to construct skb based on page to save memory copy > overhead. > > This has one problem: > > We construct the skb by fill the data page as a frag into the skb. In > this way, the linear space is empty, and the header information is also >

Re: [PATCH bpf-next] xsk: build skb by page

2021-01-18 Thread Michael S. Tsirkin
On Sat, Jan 16, 2021 at 10:44:53AM +0800, Xuan Zhuo wrote: > This patch is used to construct skb based on page to save memory copy > overhead. > > This has one problem: > > We construct the skb by fill the data page as a frag into the skb. In > this way, the linear space is empty, and the header

Re: [PATCH bpf-next] xsk: build skb by page

2021-01-18 Thread Magnus Karlsson
On Sat, Jan 16, 2021 at 3:47 AM Xuan Zhuo wrote: > > This patch is used to construct skb based on page to save memory copy > overhead. > > This has one problem: > > We construct the skb by fill the data page as a frag into the skb. In > this way, the linear space is empty, and the header informati

RE: [PATCH bpf-next] xsk: build skb by page

2021-01-17 Thread John Fastabend
Xuan Zhuo wrote: > This patch is used to construct skb based on page to save memory copy > overhead. > > This has one problem: > > We construct the skb by fill the data page as a frag into the skb. In > this way, the linear space is empty, and the header information is also > in the frag, not in

Re: [PATCH bpf-next] xsk: build skb by page

2021-01-16 Thread kernel test robot
Hi Xuan, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Xuan-Zhuo/xsk-build-skb-by-page/20210116-105116 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: sh-allm

Re: [PATCH bpf-next] xsk: build skb by page

2021-01-15 Thread kernel test robot
Hi Xuan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Xuan-Zhuo/xsk-build-skb-by-page/20210116-105116 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: s

RE: [PATCH bpf-next] xsk: build skb by page

2020-12-31 Thread John Fastabend
Xuan Zhuo wrote: > This patch is used to construct skb based on page to save memory copy > overhead. > > Taking into account the problem of addr unaligned, and the > possibility of frame size greater than page in the future. > > Signed-off-by: Xuan Zhuo > --- > net/xdp/xsk.c | 68 > +++

Re: [PATCH bpf-next] xsk: build skb by page

2020-12-23 Thread Magnus Karlsson
On Wed, Dec 23, 2020 at 9:57 AM Xuan Zhuo wrote: > > This patch is used to construct skb based on page to save memory copy > overhead. > > Taking into account the problem of addr unaligned, and the > possibility of frame size greater than page in the future. Thanks Xuan for the patch set. Could y