Re: [PATCH bpf-next] kbuild: replace BASH-specific ${@:2} with shift and ${@}

2019-09-06 Thread Alexei Starovoitov
On Fri, Sep 6, 2019 at 3:34 AM wrote: > > > > > -Original Message- > > From: Andrii Nakryiko > > Sent: Friday, September 06, 2019 3:00 AM > > To: b...@vger.kernel.org; netdev@vger.kernel.org; a...@fb.com; > > dan...@iogearbox.net > > Cc: andrii.nakry...@gmail.com; kernel-t...@fb.com; Andr

Re: [PATCH bpf-next] kbuild: replace BASH-specific ${@:2} with shift and ${@}

2019-09-06 Thread Andrii Nakryiko
On 9/6/19 12:59 AM, Yonghong Song wrote: > > > On 9/5/19 10:59 AM, Andrii Nakryiko wrote: >> ${@:2} is BASH-specific extension, which makes link-vmlinux.sh rely on >> BASH. Use shift and ${@} instead to fix this issue. >> >> Reported-by: Stephen Rothwell >> Fixes: 341dfcf8d78e ("btf: expose BTF

RE: [PATCH bpf-next] kbuild: replace BASH-specific ${@:2} with shift and ${@}

2019-09-05 Thread yamada.masahiro
> -Original Message- > From: Andrii Nakryiko > Sent: Friday, September 06, 2019 3:00 AM > To: b...@vger.kernel.org; netdev@vger.kernel.org; a...@fb.com; > dan...@iogearbox.net > Cc: andrii.nakry...@gmail.com; kernel-t...@fb.com; Andrii Nakryiko > ; Stephen Rothwell ; Yamada, > Masahiro/山

Re: [PATCH bpf-next] kbuild: replace BASH-specific ${@:2} with shift and ${@}

2019-09-05 Thread Yonghong Song
On 9/5/19 10:59 AM, Andrii Nakryiko wrote: > ${@:2} is BASH-specific extension, which makes link-vmlinux.sh rely on > BASH. Use shift and ${@} instead to fix this issue. > > Reported-by: Stephen Rothwell > Fixes: 341dfcf8d78e ("btf: expose BTF info through sysfs") > Cc: Stephen Rothwell > Cc: