Re: [PATCH RFC v1] net: dsa: microchip: add KSZ9477 I2C driver

2019-01-18 Thread Marek Vasut
On 1/18/19 9:25 PM, tristram...@microchip.com wrote: >>> +#define REG_SIZE 0x8000 >>> + >>> +#define I2C_REGMAP_VAL 8 >>> +#define I2C_REGMAP_REG 16 >>> + >>> +#define KSZ_REGMAP_COMMON(n, width) >> \ >>> +{

RE: [PATCH RFC v1] net: dsa: microchip: add KSZ9477 I2C driver

2019-01-18 Thread Tristram.Ha
> > +#define REG_SIZE 0x8000 > > + > > +#define I2C_REGMAP_VAL 8 > > +#define I2C_REGMAP_REG 16 > > + > > +#define KSZ_REGMAP_COMMON(n, width) > \ > > +{ \ > > +

Re: [PATCH RFC v1] net: dsa: microchip: add KSZ9477 I2C driver

2019-01-17 Thread Marek Vasut
On 1/17/19 4:24 AM, tristram...@microchip.com wrote: > From: Tristram Ha > > Add KSZ9477 I2C driver support. The code ksz9477.c and ksz_common.c are > used together to generate the I2C driver. > > Signed-off-by: Tristram Ha > --- > drivers/net/dsa/microchip/Kconfig | 7 ++ > drivers/n

Re: [PATCH RFC v1] net: dsa: microchip: add KSZ9477 I2C driver

2019-01-17 Thread Sergio Paracuellos
On Thu, Jan 17, 2019 at 10:36 AM Sergio Paracuellos wrote: > > On Thu, Jan 17, 2019 at 4:24 AM wrote: > > > > From: Tristram Ha > > > > Add KSZ9477 I2C driver support. The code ksz9477.c and ksz_common.c are > > used together to generate the I2C driver. > > > > Signed-off-by: Tristram Ha > > -

Re: [PATCH RFC v1] net: dsa: microchip: add KSZ9477 I2C driver

2019-01-17 Thread Sergio Paracuellos
On Thu, Jan 17, 2019 at 4:24 AM wrote: > > From: Tristram Ha > > Add KSZ9477 I2C driver support. The code ksz9477.c and ksz_common.c are > used together to generate the I2C driver. > > Signed-off-by: Tristram Ha > --- > drivers/net/dsa/microchip/Kconfig | 7 ++ > drivers/net/dsa/microc

Re: [PATCH RFC v1] net: dsa: microchip: add KSZ9477 I2C driver

2019-01-17 Thread Dan Carpenter
No need to send this as an RFC patch. Adding a new driver is normal and uncontroversial. On Wed, Jan 16, 2019 at 07:24:22PM -0800, tristram...@microchip.com wrote: > + > + i2c_set_clientdata(i2c, dev); ^^^ > + > + return 0; > +} > + > +static int ksz9477_i2