RE: [PATCH 3/3] ocelot_ace: fix action of trap

2019-08-15 Thread Y.b. Lu
elsen > Cc: Y.b. Lu ; netdev@vger.kernel.org; David S . Miller > ; Alexandre Belloni ; > Microchip Linux Driver Support > Subject: Re: [PATCH 3/3] ocelot_ace: fix action of trap > > On Wed, Aug 14, 2019 at 10:57:12AM +0200, Allan W. Nielsen wrote: > > Hi Y.b. and Andrew,

Re: [PATCH 3/3] ocelot_ace: fix action of trap

2019-08-14 Thread Andrew Lunn
On Wed, Aug 14, 2019 at 10:57:12AM +0200, Allan W. Nielsen wrote: > Hi Y.b. and Andrew, > > The 08/14/2019 04:28, Y.b. Lu wrote: > > > > I'd like to trap all IEEE 1588 PTP Ethernet frames to CPU through etype > > > 0x88f7. > > > > > > Is this the correct way to handle PTP for this switch? For oth

Re: [PATCH 3/3] ocelot_ace: fix action of trap

2019-08-14 Thread Andrew Lunn
> [Y.b. Lu] PTP messages over Ethernet will use two multicast addresses. > 01-80-C2-00-00-0E for peer delay messages. > 01-1B-19-00-00-00 for other messages. > > But only 01-80-C2-00-00-0E could be handled by hardware filter for BPDU > frames (01-80-C2-00-00-0x). > For PTP messages handling, trap

Re: [PATCH 3/3] ocelot_ace: fix action of trap

2019-08-14 Thread Allan W. Nielsen
Hi Y.b. and Andrew, The 08/14/2019 04:28, Y.b. Lu wrote: > > > I'd like to trap all IEEE 1588 PTP Ethernet frames to CPU through etype > > 0x88f7. > > > > Is this the correct way to handle PTP for this switch? For other switches we > > don't need such traps. The switch itself identifies PTP frame

Re: [PATCH 3/3] ocelot_ace: fix action of trap

2019-08-13 Thread Allan W. Nielsen
> > -Original Message- > > From: Allan W. Nielsen > > Sent: Tuesday, August 13, 2019 2:16 PM > > To: Y.b. Lu > > Cc: netdev@vger.kernel.org; David S . Miller ; > > Alexandre Belloni ; Microchip Linux Driver > > Support > > Subject

RE: [PATCH 3/3] ocelot_ace: fix action of trap

2019-08-13 Thread Y.b. Lu
Lu > > > Cc: netdev@vger.kernel.org; David S . Miller ; > > > Alexandre Belloni ; Microchip Linux > > > Driver Support > > > Subject: Re: [PATCH 3/3] ocelot_ace: fix action of trap > > > > > > The 08/12/2019 18:48, Yangbo Lu wrote: > > >

RE: [PATCH 3/3] ocelot_ace: fix action of trap

2019-08-13 Thread Y.b. Lu
Hi Allan, > -Original Message- > From: Allan W. Nielsen > Sent: Tuesday, August 13, 2019 2:16 PM > To: Y.b. Lu > Cc: netdev@vger.kernel.org; David S . Miller ; > Alexandre Belloni ; Microchip Linux Driver > Support > Subject: Re: [PATCH 3/3] ocelot_ace: fix ac

Re: [PATCH 3/3] ocelot_ace: fix action of trap

2019-08-13 Thread Andrew Lunn
Alexandre Belloni ; Microchip Linux Driver > > Support > > Subject: Re: [PATCH 3/3] ocelot_ace: fix action of trap > > > > The 08/12/2019 18:48, Yangbo Lu wrote: > > > The trap action should be copying the frame to CPU and dropping it for > > > forwarding, but curr

Re: [PATCH 3/3] ocelot_ace: fix action of trap

2019-08-12 Thread Allan W. Nielsen
> Support > > Subject: Re: [PATCH 3/3] ocelot_ace: fix action of trap > > > > The 08/12/2019 18:48, Yangbo Lu wrote: > > > The trap action should be copying the frame to CPU and dropping it for > > > forwarding, but current setting was just copying frame to CPU.

RE: [PATCH 3/3] ocelot_ace: fix action of trap

2019-08-12 Thread Y.b. Lu
Hi Allan, > -Original Message- > From: Allan W. Nielsen > Sent: Monday, August 12, 2019 8:32 PM > To: Y.b. Lu > Cc: netdev@vger.kernel.org; David S . Miller ; > Alexandre Belloni ; Microchip Linux Driver > Support > Subject: Re: [PATCH 3/3] ocelot_ace: fix actio

Re: [PATCH 3/3] ocelot_ace: fix action of trap

2019-08-12 Thread Allan W. Nielsen
The 08/12/2019 18:48, Yangbo Lu wrote: > The trap action should be copying the frame to CPU and > dropping it for forwarding, but current setting was just > copying frame to CPU. Are there any actions which do a "copy-to-cpu" and still forward the frame in HW? > Signed-off-by: Yangbo Lu > --- >