Re: [PATCH 3/3] net: usb: cdc_ncm: don't spew notifications

2021-01-19 Thread Grant Grundler
On Wed, Jan 20, 2021 at 1:05 AM Jakub Kicinski wrote: > > On Wed, 20 Jan 2021 00:59:17 + Grant Grundler wrote: > > > > Thanks for the patch, this looks like an improvement over: > > > > > > > > 59b4a8fa27f5 ("CDC-NCM: remove "connected" log message") > > > > > > > > right? Should we bring the

Re: [PATCH 3/3] net: usb: cdc_ncm: don't spew notifications

2021-01-19 Thread Jakub Kicinski
On Wed, 20 Jan 2021 00:59:17 + Grant Grundler wrote: > > > Thanks for the patch, this looks like an improvement over: > > > > > > 59b4a8fa27f5 ("CDC-NCM: remove "connected" log message") > > > > > > right? Should we bring the "network connection: connected" message back? > > > > Yes, we can r

Re: [PATCH 3/3] net: usb: cdc_ncm: don't spew notifications

2021-01-19 Thread Grant Grundler
On Wed, Jan 20, 2021 at 12:55 AM Grant Grundler wrote: > > On Tue, Jan 19, 2021 at 9:46 PM Jakub Kicinski wrote: > > > > On Fri, 15 Jan 2021 21:26:23 -0800 Grant Grundler wrote: > > > RTL8156 sends notifications about every 32ms. > > > Only display/log notifications when something changes. > > >

Re: [PATCH 3/3] net: usb: cdc_ncm: don't spew notifications

2021-01-19 Thread Grant Grundler
On Tue, Jan 19, 2021 at 9:46 PM Jakub Kicinski wrote: > > On Fri, 15 Jan 2021 21:26:23 -0800 Grant Grundler wrote: > > RTL8156 sends notifications about every 32ms. > > Only display/log notifications when something changes. > > > > This issue has been reported by others: > > https://bugs.lau

Re: [PATCH 3/3] net: usb: cdc_ncm: don't spew notifications

2021-01-19 Thread Jakub Kicinski
On Fri, 15 Jan 2021 21:26:23 -0800 Grant Grundler wrote: > RTL8156 sends notifications about every 32ms. > Only display/log notifications when something changes. > > This issue has been reported by others: > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1832472 > https://lkml.or

RE: [PATCH 3/3] net: usb: cdc_ncm: don't spew notifications

2021-01-18 Thread Hayes Wang
Grant Grundler > Sent: Tuesday, January 19, 2021 6:03 AM > Subject: Re: [PATCH 3/3] net: usb: cdc_ncm: don't spew notifications [...] > > RTL8156 sends notifications about every 32ms. > > Only display/log notifications when something changes. > > > > Thi

Re: [PATCH 3/3] net: usb: cdc_ncm: don't spew notifications

2021-01-18 Thread Grant Grundler
+nic_swsd [adding per Realtek developer team request] On Sat, Jan 16, 2021 at 5:27 AM Grant Grundler wrote: > > RTL8156 sends notifications about every 32ms. > Only display/log notifications when something changes. > > This issue has been reported by others: > https://bugs.launchpad.net/u