Re: [PATCH 2/3 v2] net: phy: DP83822 initial driver submission

2017-10-06 Thread Dan Murphy
Andrew On 10/04/2017 06:53 PM, Andrew Lunn wrote: > On Wed, Oct 04, 2017 at 10:44:36PM +, woojung@microchip.com wrote: >>> +static int dp83822_suspend(struct phy_device *phydev) >>> +{ >>> + int value; >>> + >>> + mutex_lock(&phydev->lock); >>> + value = phy_read_mmd(phydev, DP83822_

RE: [PATCH 2/3 v2] net: phy: DP83822 initial driver submission

2017-10-05 Thread Woojung.Huh
> > > +static int dp83822_suspend(struct phy_device *phydev) > > > +{ > > > + int value; > > > + > > > + mutex_lock(&phydev->lock); > > > + value = phy_read_mmd(phydev, DP83822_DEVADDR, > > > MII_DP83822_WOL_CFG); > > > + mutex_unlock(&phydev->lock); > > > Would we need mutex to access phy_read_mm

Re: [PATCH 2/3 v2] net: phy: DP83822 initial driver submission

2017-10-05 Thread Dan Murphy
Andrew On 10/04/2017 06:53 PM, Andrew Lunn wrote: > On Wed, Oct 04, 2017 at 10:44:36PM +, woojung@microchip.com wrote: >>> +static int dp83822_suspend(struct phy_device *phydev) >>> +{ >>> + int value; >>> + >>> + mutex_lock(&phydev->lock); >>> + value = phy_read_mmd(phydev, DP83822_

Re: [PATCH 2/3 v2] net: phy: DP83822 initial driver submission

2017-10-04 Thread Andrew Lunn
On Wed, Oct 04, 2017 at 10:44:36PM +, woojung@microchip.com wrote: > > +static int dp83822_suspend(struct phy_device *phydev) > > +{ > > + int value; > > + > > + mutex_lock(&phydev->lock); > > + value = phy_read_mmd(phydev, DP83822_DEVADDR, > > MII_DP83822_WOL_CFG); > > + mutex_unlo

RE: [PATCH 2/3 v2] net: phy: DP83822 initial driver submission

2017-10-04 Thread Woojung.Huh
> +static int dp83822_suspend(struct phy_device *phydev) > +{ > + int value; > + > + mutex_lock(&phydev->lock); > + value = phy_read_mmd(phydev, DP83822_DEVADDR, > MII_DP83822_WOL_CFG); > + mutex_unlock(&phydev->lock); Would we need mutex to access phy_read_mmd()? phy_read_mmd() has