Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-11-02 Thread Jeremy Linton
On 09/09/2015 11:10 AM, Marc Zyngier wrote: Jeremy, I can see two issues here: we have a screaming interrupt, and we seem to corrupt some workqueue. How did you get this to work? Firmware release? Marc, I'm responding because its been a month or so since my last response, and I haven't forg

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-10-07 Thread Rafael J. Wysocki
On 10/6/2015 1:08 PM, David Woodhouse wrote: On Mon, 2015-10-05 at 17:20 -0700, Charles Garcia-Tobin wrote: it in ACPI circles unless we had wider agreement among OSs to use it. AFAIK PRP1 has not actually been approved yet in the specification forum, and that it in itself is more of a conce

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-10-06 Thread David Woodhouse
On Mon, 2015-10-05 at 17:20 -0700, Charles Garcia-Tobin wrote: > it in ACPI circles > unless we had wider agreement among OSs to use it. AFAIK PRP1 has not > actually been approved yet in the specification forum, and that it in > itself is more of a concern for me,as the code has been pushed up

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-10-05 Thread Charles Garcia-Tobin
On 01/10/2015 03:23, "a...@redhat.com" wrote: >Adding Charles Garcia-Tobin from ARM Thanks and sorry for chiming in late. You¹ve pretty much said it all, but I had some comments. First one, is that if folk want to see what¹s happening with the DSD process, then please join the dsd mailing li

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-09-30 Thread Al Stone
Adding Charles Garcia-Tobin from ARM On 09/25/2015 09:28 AM, Catalin Marinas wrote: > On Thu, Sep 24, 2015 at 07:10:38PM +0100, David Woodhouse wrote: >> On Thu, 2015-09-24 at 16:15 +0100, Catalin Marinas wrote: >>> With "PRP0001", they can skip the _DSD properties review process (not >>> that

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-09-26 Thread David Woodhouse
On Fri, 2015-09-25 at 16:28 +0100, Catalin Marinas wrote: > > This only works as long as they target an existing driver with prior DT > support (usually with reviewed bindings). If they have a new driver and > only ACPI in mind, I'm pretty sure we'll end up with new insane things. > That's why we

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-09-25 Thread Rafael J. Wysocki
On 9/25/2015 5:28 PM, Catalin Marinas wrote: On Thu, Sep 24, 2015 at 07:10:38PM +0100, David Woodhouse wrote: On Thu, 2015-09-24 at 16:15 +0100, Catalin Marinas wrote: With "PRP0001", they can skip the _DSD properties review process (not that they bother much currently) as long as the existing

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-09-25 Thread Catalin Marinas
On Thu, Sep 24, 2015 at 07:10:38PM +0100, David Woodhouse wrote: > On Thu, 2015-09-24 at 16:15 +0100, Catalin Marinas wrote: > > With "PRP0001", they can skip the _DSD properties review process (not > > that they bother much currently) as long as the existing DT support > > covers their needs. > >

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-09-24 Thread David Woodhouse
On Thu, 2015-09-24 at 16:15 +0100, Catalin Marinas wrote: > With "PRP0001", they can skip the _DSD properties review process (not > that they bother much currently) as long as the existing DT support > covers their needs. So no change there then. I take it the smsc911x bindings didn't go through

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-09-24 Thread Catalin Marinas
On Thu, Sep 24, 2015 at 12:52:38PM +0100, David Woodhouse wrote: > On Thu, 2015-09-24 at 11:31 +0100, Catalin Marinas wrote: > > PRP0001 opens the door to any DT-like properties in ACPI and, knowing > > how the ARM ecosystem works, I'm pretty sure we'll soon lose control (if > > we haven't already;

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-09-24 Thread David Woodhouse
On Thu, 2015-09-24 at 15:01 +0100, Lorenzo Pieralisi wrote: > On Thu, Sep 24, 2015 at 12:52:38PM +0100, David Woodhouse wrote: > > [...] > > > And think about it... we *really* don't want a given peripheral device > > to have *different* bindings depending on whether it's discovered with > > a sp

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-09-24 Thread Lorenzo Pieralisi
On Thu, Sep 24, 2015 at 12:52:38PM +0100, David Woodhouse wrote: [...] > And think about it... we *really* don't want a given peripheral device > to have *different* bindings depending on whether it's discovered with > a specific ACPI HID, vs. when it's discovered via DT or the PRP0001 > HID. Tha

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-09-24 Thread David Woodhouse
Hi Catalin, I understand your concerns, but I'm still not convinced of your conclusion. On Thu, 2015-09-24 at 11:31 +0100, Catalin Marinas wrote: > PRP0001 opens the door to any DT-like properties in ACPI and, knowing > how the ARM ecosystem works, I'm pretty sure we'll soon lose control (if > we

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-09-24 Thread Catalin Marinas
Hi Dave, On Thu, Sep 24, 2015 at 09:16:19AM +0100, David Woodhouse wrote: > On Wed, 2015-09-23 at 16:56 -0700, Hanjun Guo wrote: > > It really depends on the people who writing the ASL code (DSDT), > > I'm not sure if Windows will use _DSD and how to use it, but > > firmware guys may just use the

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-09-24 Thread Catalin Marinas
On Wed, Sep 23, 2015 at 06:57:03PM +0100, Sudeep Holla wrote: > On 23/09/15 18:22, Jeremy Linton wrote: > >|FWIW, mainline booting with this patch on Juno r1 with ACPI enabled > >dies a |horrible death: > > > >Sorry about the delay, I didn't see this message. > > > > > > > >|How did you get this to

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-09-24 Thread David Woodhouse
On Wed, 2015-09-23 at 16:56 -0700, Hanjun Guo wrote: > > It really depends on the people who writing the ASL code (DSDT), > I'm not sure if Windows will use _DSD and how to use it, but > firmware guys may just use the device ID to make the firmware > to be usable both by Linux and Windows, and tha

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-09-23 Thread Hanjun Guo
On 09/23/2015 02:03 PM, David Woodhouse wrote: On Wed, 2015-09-23 at 22:51 +0200, Rafael J. Wysocki wrote: But if the device ID is assigned already, why would it hurt to actually use it? It doesn't hurt at all, as long as we understand that there was no need to assign it a device ID at all, a

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-09-23 Thread David Woodhouse
On Wed, 2015-09-23 at 22:51 +0200, Rafael J. Wysocki wrote: > > But if the device ID is assigned already, why would it hurt to > actually use it? It doesn't hurt at all, as long as we understand that there was no need to assign it a device ID at all, at least for Linux's benefit. And as long as

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-09-23 Thread Rafael J. Wysocki
On 9/23/2015 8:41 PM, David Woodhouse wrote: On Wed, 2015-08-12 at 17:06 -0500, Jeremy Linton wrote: +static const struct acpi_device_id smsc911x_acpi_match[] = { + { "ARMH9118", 0 }, + { } +}; +MODULE_DEVICE_TABLE(acpi, smsc911x_acpi_match); + static struct platform_driver smsc

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-09-23 Thread David Woodhouse
On Wed, 2015-08-12 at 17:06 -0500, Jeremy Linton wrote: > > > +static const struct acpi_device_id smsc911x_acpi_match[] = { > + { "ARMH9118", 0 }, > + { } > +}; > +MODULE_DEVICE_TABLE(acpi, smsc911x_acpi_match); > + > static struct platform_driver smsc911x_driver = { > .prob

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-09-23 Thread Sudeep Holla
On 23/09/15 18:22, Jeremy Linton wrote: Marc, |FWIW, mainline booting with this patch on Juno r1 with ACPI enabled dies a |horrible death: Sorry about the delay, I didn't see this message. |How did you get this to work? Firmware release? Yes, it's a firmware problem with the ACPI tables.

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-09-23 Thread Marc Zyngier
On Wed, 23 Sep 2015 17:22:49 + Jeremy Linton wrote: Hi Jeremy, > Marc, > > |FWIW, mainline booting with this patch on Juno r1 with ACPI enabled dies a > |horrible death: > > Sorry about the delay, I didn't see this message. > > > > |How did you get this to work? Firmware release? > > Y

RE: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-09-23 Thread Jeremy Linton
Marc, |FWIW, mainline booting with this patch on Juno r1 with ACPI enabled dies a |horrible death: Sorry about the delay, I didn't see this message. |How did you get this to work? Firmware release? Yes, it's a firmware problem with the ACPI tables. It is likely you need _DSD changes for the

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-09-09 Thread Marc Zyngier
Jeremy, On 12/08/15 23:06, Jeremy Linton wrote: > Add ACPI bindings for the smsc911x driver. Convert the DT specific calls > to nonspecific device* calls, This allows the driver to work > with both ACPI and DT configurations. Ethernet should now work when using > ACPI on ARM Juno. > > Signed-off-

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-08-13 Thread Lorenzo Pieralisi
On Thu, Aug 13, 2015 at 10:38:38AM +0100, Graeme Gregory wrote: > On Thu, Aug 13, 2015 at 10:01:17AM +0100, Lorenzo Pieralisi wrote: > > On Thu, Aug 13, 2015 at 09:27:59AM +0100, Graeme Gregory wrote: > > > On Wed, Aug 12, 2015 at 05:06:27PM -0500, Jeremy Linton wrote: > > > > Add ACPI bindings for

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-08-13 Thread Graeme Gregory
On Thu, Aug 13, 2015 at 10:01:17AM +0100, Lorenzo Pieralisi wrote: > On Thu, Aug 13, 2015 at 09:27:59AM +0100, Graeme Gregory wrote: > > On Wed, Aug 12, 2015 at 05:06:27PM -0500, Jeremy Linton wrote: > > > Add ACPI bindings for the smsc911x driver. Convert the DT specific calls > > > to nonspecific

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-08-13 Thread Lorenzo Pieralisi
On Thu, Aug 13, 2015 at 09:27:59AM +0100, Graeme Gregory wrote: > On Wed, Aug 12, 2015 at 05:06:27PM -0500, Jeremy Linton wrote: > > Add ACPI bindings for the smsc911x driver. Convert the DT specific calls > > to nonspecific device* calls, This allows the driver to work > > with both ACPI and DT co

Re: [PATCH 2/2] Convert smsc911x to use ACPI as well as DT

2015-08-13 Thread Graeme Gregory
On Wed, Aug 12, 2015 at 05:06:27PM -0500, Jeremy Linton wrote: > Add ACPI bindings for the smsc911x driver. Convert the DT specific calls > to nonspecific device* calls, This allows the driver to work > with both ACPI and DT configurations. Ethernet should now work when using > ACPI on ARM Juno. >