Re: [PATCH 1/4] Try 2: Add wireless statistics to d80211

2006-08-24 Thread Larry Finger
Simon Barber wrote: Why have both signal and rssi measures? In the bcm43xx driver, the values are different. There is a routine that converts from rssi as a positive number into signal in a negative number that looks like dBm. Because of the reverse engineering, we have no idea what the logic

RE: [PATCH 1/4] Try 2: Add wireless statistics to d80211

2006-08-24 Thread Simon Barber
Why have both signal and rssi measures? Simon -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Larry Finger Sent: Wednesday, August 23, 2006 8:02 PM To: Jiri Benc Cc: John Linville; netdev@vger.kernel.org Subject: [PATCH 1/4] Try 2: Add wireless statistic

Re: [PATCH 1/4] Try 2: Add wireless statistics to d80211

2006-08-24 Thread Jiri Benc
On Thu, 24 Aug 2006 09:39:52 -0500, Larry Finger wrote: > Noted on the first part, but I would like a clarification regarding style. I > put the */ on the > second line to match the rest of that section. Should a patch try to keep the > local style in that > part of the code, or change it to a

Re: [PATCH 1/4] Try 2: Add wireless statistics to d80211

2006-08-24 Thread Larry Finger
Jiri Benc wrote: On Wed, 23 Aug 2006 22:02:03 -0500, Larry Finger wrote: This patch modifies d80211 to add wireless statistics. + /* This is maximum value of rssi reported by this interface +*/ + int maxssi; Device, not interface. And please do not put */ to a new line. N

Re: [PATCH 1/4] Try 2: Add wireless statistics to d80211

2006-08-24 Thread Jiri Benc
On Wed, 23 Aug 2006 22:02:03 -0500, Larry Finger wrote: > This patch modifies d80211 to add wireless statistics. > > Signed-Off-By: Larry [EMAIL PROTECTED]> Please fix the Signed-off-by line. > > == > diff --git a/include/net/d80211.h b/include/net/d80211.h >