RE: [PATCH 1/2] can: rcar_can: Add r8a7795 support

2016-02-29 Thread Ramesh Shanmugasundaram
Hi Marc, > On 02/29/2016 11:00 AM, Marc Kleine-Budde wrote: > > I think it's better to fix the algorithm. I'll look into it. > > What about: > > > ./can-calc-bit-timing -c 3998 rcar_can > > Bit timing parameters for rcar_can with 39.98 MHz ref clock > > nominal

Re: [PATCH 1/2] can: rcar_can: Add r8a7795 support

2016-02-29 Thread Marc Kleine-Budde
On 02/29/2016 11:00 AM, Marc Kleine-Budde wrote: > I think it's better to fix the algorithm. I'll look into it. What about: > ./can-calc-bit-timing -c 3998 rcar_can > > Bit timing parameters for rcar_can with 39.98 MHz ref clock >

RE: [PATCH 1/2] can: rcar_can: Add r8a7795 support

2016-02-29 Thread Ramesh Shanmugasundaram
Hi Geert, > On Mon, Feb 29, 2016 at 10:21 AM, Ramesh Shanmugasundaram > wrote: > > --- a/drivers/net/can/rcar_can.c > > +++ b/drivers/net/can/rcar_can.c > > @@ -808,6 +808,10 @@ static int rcar_can_probe(struct platform_device > *pdev) > > priv->regs = addr; > > priv->clock_select

Re: [PATCH 1/2] can: rcar_can: Add r8a7795 support

2016-02-29 Thread Marc Kleine-Budde
On 02/29/2016 10:56 AM, Ramesh Shanmugasundaram wrote: > root@salvator-x:~# can-calc-bit-timing -c 3998 rcar_can Can you send me the patches to support the rcar_can. On the linux-can ML or github pull request. Thanks, Marc -- Pengutronix e.K. | Marc Kleine-Budde

Re: [PATCH 1/2] can: rcar_can: Add r8a7795 support

2016-02-29 Thread Marc Kleine-Budde
On 02/29/2016 10:56 AM, Ramesh Shanmugasundaram wrote: >> On 02/29/2016 10:21 AM, Ramesh Shanmugasundaram wrote: >>> Added r8a7795 SoC support. >>> >>> For smoother bit timing calculation, the rounded clock frequency is >> used. >> >> Why this? From my point of view this introduces a clock error. >

RE: [PATCH 1/2] can: rcar_can: Add r8a7795 support

2016-02-29 Thread Ramesh Shanmugasundaram
Hi Marc, > On 02/29/2016 10:21 AM, Ramesh Shanmugasundaram wrote: > > Added r8a7795 SoC support. > > > > For smoother bit timing calculation, the rounded clock frequency is > used. > > Why this? From my point of view this introduces a clock error. Thanks for the comments. Without the rounded c

Re: [PATCH 1/2] can: rcar_can: Add r8a7795 support

2016-02-29 Thread Geert Uytterhoeven
Hi Ramesh, On Mon, Feb 29, 2016 at 10:21 AM, Ramesh Shanmugasundaram wrote: > --- a/drivers/net/can/rcar_can.c > +++ b/drivers/net/can/rcar_can.c > @@ -808,6 +808,10 @@ static int rcar_can_probe(struct platform_device *pdev) > priv->regs = addr; > priv->clock_select = clock_select

Re: [PATCH 1/2] can: rcar_can: Add r8a7795 support

2016-02-29 Thread Marc Kleine-Budde
On 02/29/2016 10:21 AM, Ramesh Shanmugasundaram wrote: > Added r8a7795 SoC support. > > For smoother bit timing calculation, the rounded clock frequency is used. Why this? From my point of view this introduces a clock error. Marc -- Pengutronix e.K. | Marc Kleine-Budde