From: Sony Chacko
Date: Wed, 29 Jun 2016 17:51:34 -0400
> Call wmb() to ensure writes are complete before
> hardware fetches updated Tx descriptors.
>
> Signed-off-by: Sony Chacko
Applied, thanks.
Subject: Re: [PATCH 1/1] qlcnic: add wmb() call in transmit data path.
>
>> +/* Ensure writes are complete before HW fetches Tx descriptors */
>> +wmb();
>> qlcnic_update_cmd_producer(tx_ring);
>>
>> return NETDEV_TX_OK;
>>
>
> Wo
On 30.06.2016 17:32, Lino Sanfilippo wrote:
Hi,
On 29.06.2016 23:51, Sony Chacko wrote:
+/* Ensure writes are complete before HW fetches Tx descriptors */
+wmb();
qlcnic_update_cmd_producer(tx_ring);
return NETDEV_TX_OK;
Would not an mmiowb be more appropriate in this
Hi,
On 29.06.2016 23:51, Sony Chacko wrote:
+ /* Ensure writes are complete before HW fetches Tx descriptors */
+ wmb();
qlcnic_update_cmd_producer(tx_ring);
return NETDEV_TX_OK;
Would not an mmiowb be more appropriate in this case?
Regards,
Lino
